Skip to content

Commit ab7b53f

Browse files
Merge pull request #41 from raphaelfabeni/development
Updating webpack and webpack-dev-server
2 parents 14abb9b + e9ad3d7 commit ab7b53f

File tree

3 files changed

+1628
-903
lines changed

3 files changed

+1628
-903
lines changed

README.md

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -387,17 +387,15 @@ This loader differs from the other because we have to pass an attribute to it, a
387387
## Contributing
388388

389389
1. Clone this repository.
390-
2. `yarn install` and `yarn serve`
391-
3. Open => `http://localhost:3000` (if it didn't open automatically)
390+
2. Run `yarn install` and `yarn start`
391+
3. Open `http://localhost:3000`.
392392
4. Make your magic contribution.
393-
4.1. Choose a special name for your loader (`loaders-name-you-want`) and add to `loaders.json`.
394-
4.2. Creates the example file inside the `examples` folder (uses the loader name you chose). You can copy one of the examples and make the necessary changes.
395-
4.3. Creates the `.sass` files. The first one inside `src` folder which is the root style file for the loader and it will import the other files. And the other one, inside `loaders` folder with the specific style for the loader (both must have the same name you chose - _loader-name-you-chose_).
393+
* Choose a special name for your loader (`loaders-name-you-want`) and add to `loaders.json`.
394+
* Create the example file inside the `examples` folder (uses the loader name you chose). You can copy one of the examples and make the necessary changes.
395+
* Create the `.sass` files. The first one inside `src` folder which is the root style file for the loader and it will import the other files. And the other one, inside `loaders` folder with the specific style for the loader (both must have the same name you chose - _loader-name-you-chose_).
396396
5. Run `yarn build` to create/update the dist files.
397397
6. Open a _PR_ with a new branch describing your changes. <o/
398398

399-
## Browser Support
400-
401399
All examples use CSS _animation_ which is supported by [most current browsers](http://caniuse.com/#search=animation).
402400

403401
| <img src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/chrome/chrome_128x128.png" width="48px" height="48px" alt="Chrome logo"> | <img src="https://github.com/alrra/browser-logos/blob/master/src/firefox/firefox_128x128.png?raw=true" width="48px" height="48px" alt="Firefox logo"> | <img src="https://cdnjs.cloudflare.com/ajax/libs/browser-logos/40.2.1/archive/internet-explorer_9-11/internet-explorer_9-11_128x128.png" width="48px" height="48px" alt="Internet Explorer logo"> | <img src="https://github.com/alrra/browser-logos/blob/master/src/opera/opera_128x128.png?raw=true" width="48px" height="48px" alt="Opera logo"> | <img src="https://github.com/alrra/browser-logos/blob/master/src/safari/safari_128x128.png?raw=true" width="48px" height="48px" alt="Safari logo"> | <img src="https://github.com/alrra/browser-logos/blob/master/src/android/android_128x128.png?raw=true" width="48px" height="48px" alt="Android Browser Logo" >

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"main": "index.js",
77
"scripts": {
88
"build": "rimraf dist && webpack && rimraf dist/*.js",
9-
"serve": "webpack-dev-server"
9+
"start": "webpack-dev-server"
1010
},
1111
"author": "Raphael Fabeni",
1212
"license": "MIT",
@@ -20,8 +20,8 @@
2020
"sass-loader": "^6.0.6",
2121
"sasslint-webpack-plugin": "^1.0.4",
2222
"style-loader": "^0.18.2",
23-
"webpack": "^3.5.5",
24-
"webpack-dev-server": "^2.7.1",
23+
"webpack": "3.8.1",
24+
"webpack-dev-server": "2.11.1",
2525
"webpack-livereload-plugin": "^0.11.0"
2626
}
2727
}

0 commit comments

Comments
 (0)