Fixes generated or modified header

Author: raphaelstolt

src/Commands/ValidateCommand.php

@@ -307,7 +307,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $globPattern = $input->getOption('glob-pattern');
         $globPatternFile = (string) $input->getOption('glob-pattern-file');
         $omitHeader = (boolean) $input->getOption('omit-header');
-
         $showDifference = $input->getOption('diff');
         $reportStaleExportIgnores = $input->getOption('report-stale-export-ignores');
 
@@ -477,7 +476,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
                     try {
                         $outputContent .= $this->gitattributesFileRepository->createGitattributesFile(
                             $expectedGitattributesFileContent,
-                            $omitHeader
+                            $omitHeader === true ? false : true
                         );
                         $output->writeln($outputContent);
 

src/GitattributesFileRepository.php

@@ -29,7 +29,7 @@ public function __construct(Analyser $analyser)
      */
     public function createGitattributesFile(string $content, bool $withHeader = true): string
     {
-        // Ensure the "generated by" header is present when requested.
+        // Ensure the generated or modified by header is present when requested
         if ($withHeader) {
             $content = $this->applyOverwriteHeaderPolicy($content);
         }

tests/Commands/ValidateCommandTest.php

@@ -848,7 +848,9 @@ public function validateOnNonExistentGitattributesFilesWithCreationOptionCreates
 
         $this->assertStringNotContainsString(GitattributesFileRepository::GENERATED_HEADER, $commandTester->getDisplay());
         $this->assertStringNotContainsString(GitattributesFileRepository::MODIFIED_HEADER, $commandTester->getDisplay());
+
         $commandTester->assertCommandIsSuccessful();
+
         $this->assertFileExists(
             WORKING_DIRECTORY . DIRECTORY_SEPARATOR . '.gitattributes'
         );
@@ -1566,6 +1568,35 @@ public function createdHeaderIsReplacedByModifiedHeader(): void
         );
     }
 
+    #[Test]
+    public function addsCreatedHeaderAsExpected(): void
+    {
+        $artifactFilenames = ['phpspec.yml.dist', 'version-increase-command'];
+
+        $this->createTemporaryFiles(
+            $artifactFilenames,
+            ['specs']
+        );
+
+        $command = $this->application->find('validate');
+        $commandTester = new CommandTester($command);
+        $commandTester->execute([
+            'command' => $command->getName(),
+            'directory' => WORKING_DIRECTORY,
+            '--create' => true,
+            '--omit-header' => false,
+        ]);
+
+        $commandTester->assertCommandIsSuccessful();
+        $this->assertFileExists(
+            WORKING_DIRECTORY . DIRECTORY_SEPARATOR . '.gitattributes'
+        );
+        $this->assertStringContainsString(
+            GitattributesFileRepository::GENERATED_HEADER,
+            \file_get_contents(WORKING_DIRECTORY . DIRECTORY_SEPARATOR . '.gitattributes')
+        );
+    }
+
     #[Test]
     #[Ticket('https://github.com/raphaelstolt/lean-package-validator/issues/8')]
     #[DataProvider('optionProvider')]
@@ -1588,15 +1619,7 @@ public function incompleteGitattributesFileIsOverwritten(string $option): void
             ['specs']
         );
 
-        $header = GitattributesFileRepository::GENERATED_HEADER . PHP_EOL . PHP_EOL;
-
-        if ($option === '--overwrite') {
-            $header = GitattributesFileRepository::MODIFIED_HEADER . PHP_EOL;
-        }
-
-        if ($option === '--create') {
-            $header = GitattributesFileRepository::MODIFIED_HEADER . PHP_EOL . PHP_EOL;
-        }
+        $header = GitattributesFileRepository::MODIFIED_HEADER . PHP_EOL;
 
         $command = $this->application->find('validate');
         $commandTester = new CommandTester($command);