Updates phpstan/phpstan

Author: raphaelstolt

composer.json

@@ -65,7 +65,7 @@
         "mockery/mockery": "^1.0",
         "phlak/semver": "^4.1 || ^6.0",
         "php-mock/php-mock-phpunit": "^2.7||^1.1",
-        "phpstan/phpstan": "^1.11",
+        "phpstan/phpstan": "^2.0",
         "phpunit/phpunit": "^11.2.6||^10.5.25",
         "zenstruck/console-test": "^1.6"
     }

phpstan.neon.dist

@@ -3,9 +3,13 @@ parameters:
     paths:
         - src
         - tests
+    treatPhpDocTypesAsCertain: false
     reportUnmatchedIgnoredErrors: false
     ignoreErrors:
         - identifier: missingType.iterableValue
+        - identifier: argument.type
+        - identifier: identical.alwaysTrue
+        - identifier: method.alreadyNarrowedType
         - '#Constant WORKING_DIRECTORY not found.#'
         - '#Mockery\\MockInterface#'
         - '#Mockery\\LegacyMockInterface#'

src/Commands/InitCommand.php

@@ -109,6 +109,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $directory = (string) $input->getArgument('directory');
         $overwriteDefaultLpvFile = $input->getOption('overwrite');
         $chosenPreset = (string) $input->getOption('preset');
+        $globPatternFromPreset = false;
 
         if ($directory !== WORKING_DIRECTORY) {
             try {
@@ -159,9 +160,11 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         );
 
         $verboseOutput = '+ Writing default glob pattern to .lpv file in ' . WORKING_DIRECTORY . '.';
+
         if ($globPatternFromPreset === true) {
             $verboseOutput = '+ Writing glob pattern for preset ' . $chosenPreset . ' to .lpv file in ' . WORKING_DIRECTORY . '.';
         }
+
         $output->writeln($verboseOutput, OutputInterface::VERBOSITY_VERBOSE);
 
         if ($bytesWritten === false) {

tests/Commands/ValidateCommandTest.php

@@ -179,7 +179,7 @@ public function showsDifferenceBetweenActualAndExpectedGitattributesContent(): v
             '--diff' => true,
         ]);
 
-        $actualDisplayRows = \array_values(\explode(PHP_EOL, $commandTester->getDisplay()));
+        $actualDisplayRows = \explode(PHP_EOL, $commandTester->getDisplay());
         $expectedDiffRows = ['--- Original', '+++ Expected', '@@ -1 +1,2 @@'];
 
         foreach ($expectedDiffRows as $expectedDiffRow) {

tests/Presets/FinderTest.php

@@ -33,7 +33,8 @@ public function findsExpectedPresetGlobByLanguageNames(string $languageName): vo
     {
         $finder = new Finder(new PhpPreset());
         $presetGlob = $finder->getPresetGlobByLanguageName($languageName);
-        $this->assertTrue(\is_array($presetGlob));
+
+        $this->assertIsArray($presetGlob);
     }
 
     #[Test]

tests/TestCase.php

@@ -74,7 +74,7 @@ protected function createTemporaryFiles(array $files, array $directories = [])
             \touch($artifactFile);
         }
 
-        if (\is_array($directories) && \count($directories) > 0) {
+        if (\count($directories) > 0) {
             foreach ($directories as $directory) {
                 $artifactDirectory = $this->temporaryDirectory
                     . DIRECTORY_SEPARATOR