Fixes issue where no package name is set

Author: raphaelstolt

src/Commands/TreeCommand.php

@@ -16,6 +16,8 @@ final class TreeCommand extends Command
 {
     private Tree $tree;
 
+    private const UNKNOWN_PACKAGE_NAME = 'unknown/unknown';
+
     private string $directoryToOperateOn;
 
     public function __construct(Tree $tree)
@@ -97,13 +99,18 @@ protected function execute(InputInterface $input, OutputInterface $output): int
     protected function getPackageName(): string
     {
         if (!\file_exists($this->directoryToOperateOn . DIRECTORY_SEPARATOR . 'composer.json')) {
-            return 'unknown/unknown';
+            return self::UNKNOWN_PACKAGE_NAME;
         }
 
         $composerContentAsJson = \json_decode(
             \file_get_contents($this->directoryToOperateOn . DIRECTORY_SEPARATOR . 'composer.json'),
             true
         );
+
+        if (!isset($composerContentAsJson['name'])) {
+            return self::UNKNOWN_PACKAGE_NAME;
+        }
+
         return \trim($composerContentAsJson['name']);
     }
 }

src/Helpers/Str.php

@@ -19,20 +19,4 @@ public function isWindows(string $os = PHP_OS): bool
 
         return true;
     }
-
-    /**
-     * Check if the operating system is macish.
-     *
-     * @param string $os
-     *
-     * @return boolean
-     */
-    public function isMacOs(string $os = PHP_OS): bool
-    {
-        if (\strtoupper(\substr($os, 0, 3)) !== 'DAR') {
-            return false;
-        }
-
-        return true;
-    }
 }

tests/Commands/TreeCommandTest.php

@@ -11,6 +11,7 @@
 use Stolt\LeanPackage\Tests\CommandTester;
 use Stolt\LeanPackage\Tests\TestCase;
 use Stolt\LeanPackage\Tree;
+use Symfony\Component\Console\Command\Command;
 
 class TreeCommandTest extends TestCase
 {
@@ -63,6 +64,49 @@ public function displaysExpectedSrcTree(): void
         ]);
 
         $this->assertStringContainsString('5 directories, 2 files', $commandTester->getDisplay());
+        $this->assertStringContainsString('Package: test-src/package', $commandTester->getDisplay());
+        $commandTester->assertCommandIsSuccessful();
+    }
+
+    #[Test]
+    public function displaysExpectedDefaultPackageName(): void
+    {
+        $command = $this->application->find('tree');
+        $commandTester = new CommandTester($command);
+
+        $artifactFilenames = [
+            '.gitattributes',
+            'composer.json',
+        ];
+
+        $this->createTemporaryFiles(
+            $artifactFilenames,
+            ['src', 'tests', '.github', 'docs', 'bin']
+        );
+
+        $commandTester->execute([
+            'command' => $command->getName(),
+            'directory' => $this->temporaryDirectory,
+            '--src' => true
+        ]);
+
+        $this->assertStringContainsString('unknown/unknown', $commandTester->getDisplay());
+        $commandTester->assertCommandIsSuccessful();
+    }
+
+    #[Test]
+    public function displaysExpectedDistPackageTree(): void
+    {
+        $command = $this->application->find('tree');
+        $commandTester = new CommandTester($command);
+
+        $commandTester->execute([
+            'command' => $command->getName(),
+            'directory' => '.'
+        ]);
+
+        $this->assertStringContainsString('2 directories, 1 file', $commandTester->getDisplay());
+        $this->assertStringContainsString('Package: stolt/lean-package-validator', $commandTester->getDisplay());
         $commandTester->assertCommandIsSuccessful();
     }
 }

tests/TreeTest.php

@@ -0,0 +1,22 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Stolt\LeanPackage\Tests;
+
+use PHPUnit\Framework\Attributes\Test;
+use Stolt\LeanPackage\Archive;
+use Stolt\LeanPackage\Exceptions\GitHeadNotAvailable;
+use Stolt\LeanPackage\Tree;
+
+class TreeTest extends TestCase
+{
+    #[Test]
+    public function throwsExpectedExceptionWhenNoGitHeadAvailable(): void
+    {
+        $this->expectException(GitHeadNotAvailable::class);
+        $this->expectExceptionMessage('No Git HEAD present to create an archive from.');
+
+        (new Tree(new Archive(\sys_get_temp_dir())))->getTreeForDistPackage(\sys_get_temp_dir());
+    }
+}