Skip to content

Commit 596ac8e

Browse files
committed
use borrowed ID
1 parent 3bd5481 commit 596ac8e

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

docs/docs/releases.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,12 @@ language: 'en'
1616
- Graphics are now properly removed when cells containing them are overwritten
1717
- Fixes issues with file managers like Yazi where images would persist incorrectly
1818
- Simplified graphics cleanup logic by removing unused ClearSubregion functionality
19+
- **CJK Font Metrics**: Fixed CJK characters displaying "higher" than Latin characters [#1071](https://github.com/raphamorim/rio/issues/1071)
20+
- Implemented comprehensive CJK font metrics handling with consistent baseline adjustment
21+
- Fixed scrolling issues for mixed Latin and CJK text content
22+
- Added CJK character width measurement using "水" (water ideograph) as reference
23+
- Created consistent cell dimensions across different font types
24+
- Developed extensive test suite with 40+ font-related tests to verify fixes
1925

2026
## 0.2.26
2127

@@ -193,12 +199,6 @@ These changes are particularly beneficial for:
193199

194200
### Bug Fixes
195201

196-
- **CJK Font Metrics**: Fixed CJK characters displaying "higher" than Latin characters [#1071](https://github.com/raphamorim/rio/issues/1071)
197-
- Implemented comprehensive CJK font metrics handling with consistent baseline adjustment
198-
- Fixed scrolling issues for mixed Latin and CJK text content
199-
- Added CJK character width measurement using "水" (water ideograph) as reference
200-
- Created consistent cell dimensions across different font types
201-
- Developed extensive test suite with 40+ font-related tests to verify fixes
202202
- **Backspace Key Compatibility**: Fixed backspace key not working properly in vim when `TERM=xterm-256color`
203203
- Changed backspace key bindings to send BS (0x08) instead of DEL (0x7F)
204204
- Updated Rio terminfo and termcap entries to match actual key behavior

sugarloaf/src/font/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ impl FontLibraryData {
261261
primary_metrics
262262
};
263263

264-
if *font_id == FONT_ID_REGULAR {
264+
if font_id == &FONT_ID_REGULAR {
265265
// Primary font uses its own metrics
266266
Some(primary_metrics.for_rich_text())
267267
} else {

sugarloaf/src/layout/content.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,6 @@ impl BuilderState {
184184
pub fn update_font_size(&mut self) {
185185
let font_size = self.layout.font_size;
186186
let scale = self.layout.dimensions.scale;
187-
let _prev_font_size = self.scaled_font_size;
188187
self.scaled_font_size = font_size * scale;
189188

190189
self.last_update = BuilderStateUpdate::Full;

0 commit comments

Comments
 (0)