Adds safety for illegally compiled parameters.

Author: raphw

byte-buddy-dep/src/main/java/net/bytebuddy/asm/Advice.java

@@ -10612,7 +10612,7 @@ protected void propagateHandler(Label label) {
                 }
 
                 @Override
-                public void visitParameter(String name, int modifiers) {
+                public void visitParameter(@MaybeNull String name, int modifiers) {
                     /* do nothing */
                 }
 

byte-buddy-dep/src/main/java/net/bytebuddy/description/method/ParameterDescription.java

@@ -33,6 +33,7 @@
 import net.bytebuddy.utility.dispatcher.JavaDispatcher;
 import net.bytebuddy.utility.nullability.AlwaysNull;
 import net.bytebuddy.utility.nullability.MaybeNull;
+import org.objectweb.asm.Opcodes;
 
 import java.lang.annotation.Annotation;
 import java.lang.reflect.AccessibleObject;
@@ -230,6 +231,13 @@ public String toString() {
      */
     abstract class ForLoadedParameter<T extends AccessibleObject> extends InDefinedShape.AbstractBase {
 
+        /**
+         * The name of the {@code java.lang.reflect.MalformedParametersException}. Due to compiler bugs, parameter
+         * declarations might not always be legal, and by checking for this exception, one can trigger a fallback
+         * behaviour.
+         */
+        private static final String MALFORMED_PARAMETERS_EXCEPTION = "java.lang.reflect.MalformedParametersException";
+
         /**
          * A dispatcher for reading properties from {@code java.lang.reflect.Parameter} instances.
          */
@@ -279,7 +287,14 @@ private static <T> T doPrivileged(PrivilegedAction<T> action) {
          * {@inheritDoc}
          */
         public String getName() {
-            return PARAMETER.getName(ParameterList.ForLoadedExecutable.EXECUTABLE.getParameters(executable)[index]);
+            try {
+                return PARAMETER.getName(ParameterList.ForLoadedExecutable.EXECUTABLE.getParameters(executable)[index]);
+            } catch (RuntimeException exception) {
+                if (exception.getClass().getName().equals(MALFORMED_PARAMETERS_EXCEPTION)) {
+                    return super.getName();
+                }
+                throw exception;
+            }
         }
 
         /**
@@ -293,14 +308,28 @@ public int getIndex() {
          * {@inheritDoc}
          */
         public boolean isNamed() {
-            return PARAMETER.isNamePresent(ParameterList.ForLoadedExecutable.EXECUTABLE.getParameters(executable)[index]);
+            try {
+                return PARAMETER.isNamePresent(ParameterList.ForLoadedExecutable.EXECUTABLE.getParameters(executable)[index]);
+            } catch (RuntimeException exception) {
+                if (exception.getClass().getName().equals(MALFORMED_PARAMETERS_EXCEPTION)) {
+                    return false;
+                }
+                throw exception;
+            }
         }
 
         /**
          * {@inheritDoc}
          */
         public int getModifiers() {
-            return PARAMETER.getModifiers(ParameterList.ForLoadedExecutable.EXECUTABLE.getParameters(executable)[index]);
+            try {
+                return PARAMETER.getModifiers(ParameterList.ForLoadedExecutable.EXECUTABLE.getParameters(executable)[index]);
+            } catch (RuntimeException exception) {
+                if (exception.getClass().getName().equals(MALFORMED_PARAMETERS_EXCEPTION)) {
+                    return super.getModifiers();
+                }
+                throw exception;
+            }
         }
 
         /**

byte-buddy-dep/src/main/java/net/bytebuddy/pool/TypePool.java

@@ -9845,7 +9845,7 @@ public void visitLocalVariable(String name, String descriptor, String signature,
                 }
 
                 @Override
-                public void visitParameter(String name, int modifiers) {
+                public void visitParameter(@MaybeNull String name, int modifiers) {
                     parameterTokens.add(new LazyTypeDescription.MethodToken.ParameterToken(name, modifiers));
                 }