Merge pull request #20170 from bcoles/msf-module-uuid

Msf::Module::UUID: Generate UUID using UUID_CHARS.sample(8).join

Author: adfoster-r7

lib/msf/core/module.rb

@@ -114,7 +114,6 @@ def initialize(info = {})
       @module_info_copy = info.dup
 
       self.module_info = info
-      generate_uuid
 
       set_defaults
 

lib/msf/core/module/uuid.rb

@@ -1,13 +1,18 @@
-require 'rex/text'
-
+# NOTE: Metasploit does not use real UUIDs currently.
+# To modify this to be a real UUID we will need to do a database migration.
+# See: https://github.com/rapid7/metasploit-framework/pull/20170
 module Msf::Module::UUID
+  UUID_CHARS = [*('a'..'z'), *('0'..'9')].freeze
+  private_constant :UUID_CHARS
+
   #
   # Attributes
   #
 
-  # @!attribute [r] uuid
-  #   A unique identifier for this module instance
-  attr_reader :uuid
+  # @return [String] A unique identifier for this module instance
+  def uuid
+    @uuid ||= UUID_CHARS.sample(8).join
+  end
 
   protected
 
@@ -17,13 +22,4 @@ module Msf::Module::UUID
 
   # @!attribute [w] uuid
   attr_writer :uuid
-
-
-  #
-  # Instance Methods
-  #
-
-  def generate_uuid
-    self.uuid = Rex::Text.rand_text_alphanumeric(8).downcase
-  end
 end