Skip to content

Commit 2b6999a

Browse files
committed
Update docs dependency rexml
1 parent 66f6cac commit 2b6999a

File tree

4 files changed

+14
-2
lines changed

4 files changed

+14
-2
lines changed

.github/workflows/verify.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ jobs:
5757
--health-retries 5
5858
5959
strategy:
60-
fail-fast: true
60+
fail-fast: false
6161
matrix:
6262
ruby:
6363
- '3.1'

docs/Gemfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ GEM
7676
rb-fsevent (0.11.2)
7777
rb-inotify (0.11.1)
7878
ffi (~> 1.0)
79-
rexml (3.3.9)
79+
rexml (3.4.0)
8080
rouge (4.5.1)
8181
safe_yaml (1.0.5)
8282
sassc (2.4.0)

lib/msf/core/windows_version.rb

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -232,8 +232,12 @@ def xp_or_2003?
232232
# @param build [Integer] The build build number reported in the NTLM handshake
233233
# @return [String] The possible matching OS versions, or nil if no corresponding match can be found
234234
def self.from_ntlm_os_version(major, minor, build)
235+
puts [major, minor, build].inspect
235236
workstation_string = self.version_string(major, minor, build, WorkstationSpecificVersions, WorkstationNameMapping)
237+
puts ["workstation_string:", workstation_string].inspect
238+
236239
server_string = self.version_string(major, minor, build, ServerSpecificVersions, ServerNameMapping)
240+
puts ["server_string:", server_string].inspect
237241

238242
version_strings = []
239243
version_strings.append(workstation_string) unless workstation_string.nil?
@@ -292,14 +296,20 @@ def major_release_name
292296

293297
# Get a Windows OS version string representation for a given major, minor and build number
294298
def self.version_string(major, minor, build, version_module, mapping)
299+
puts version_module.constants.inspect
295300
version_module.constants.each do |version_sym|
301+
puts "version_sym: #{version_sym}"
296302
version = version_module.const_get(version_sym)
303+
puts "version: #{version}"
297304
segments = version.segments
305+
puts "segments: #{segments.inspect}"
298306
if segments[0..2] == [major, minor, build]
307+
puts "matched: #{segments[0..2]} == #{[major, minor, build].inspect}"
299308
return mapping[version_sym]
300309
end
301310
end
302311

312+
puts "nil scenario"
303313
nil
304314
end
305315
end

spec/lib/msf/core/windows_version_spec.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,9 @@
4545
major = 5
4646
minor = 1
4747
build = 2600
48+
puts "running test"
4849
version_string = described_class.from_ntlm_os_version(major, minor, build)
50+
puts "finishing test before assertion"
4951
expect(version_string).to eq('Windows XP')
5052
end
5153

0 commit comments

Comments
 (0)