Adds tests for nil scenarios

Author: cgranleese-r7

lib/msf/core/modules/metadata/search.rb

@@ -179,17 +179,17 @@ def is_match(params, module_metadata, regex_cache)
             when 'aka'
               match = [keyword, search_term] if (module_metadata.notes['AKA'] || []).any? { |aka| aka =~ regex }
             when 'author', 'authors'
-              match = [keyword, search_term] if module_metadata.author && module_metadata.author.any? { |author| author =~ regex }
+              match = [keyword, search_term] if module_metadata.author.any? { |author| author =~ regex }
             when 'arch'
               match = [keyword, search_term] if module_metadata.arch =~ regex
             when 'cve'
-              match = [keyword, search_term] if module_metadata.references && module_metadata.references.any? { |ref| ref =~ /^cve\-/i and ref =~ regex }
+              match = [keyword, search_term] if module_metadata.references.any? { |ref| ref =~ /^cve\-/i and ref =~ regex }
             when 'osvdb'
-              match = [keyword, search_term] if module_metadata.references && module_metadata.references.any? { |ref| ref =~ /^osvdb\-/i and ref =~ regex }
+              match = [keyword, search_term] if module_metadata.references.any? { |ref| ref =~ /^osvdb\-/i and ref =~ regex }
             when 'bid'
-              match = [keyword, search_term] if module_metadata.references && module_metadata.references.any? { |ref| ref =~ /^bid\-/i and ref =~ regex }
+              match = [keyword, search_term] if module_metadata.references.any? { |ref| ref =~ /^bid\-/i and ref =~ regex }
             when 'edb'
-              match = [keyword, search_term] if module_metadata.references && module_metadata.references.any? { |ref| ref =~ /^edb\-/i and ref =~ regex }
+              match = [keyword, search_term] if module_metadata.references.any? { |ref| ref =~ /^edb\-/i and ref =~ regex }
             when 'check'
               if module_metadata.check
                 matches_check = %w(true yes).any? { |val| val =~ regex}

spec/lib/msf/core/modules/metadata/search_spec.rb

@@ -154,6 +154,13 @@ def inverse_query_terms(search_string)
       it_should_behave_like 'search_filter', :accept => accept, :reject => reject
     end
 
+    context 'on a module with a #author of nil' do
+      let(:opts) { ({ 'author' => [nil] }) }
+      reject = %w(author:foo)
+
+      it_should_behave_like 'search_filter', :reject => reject
+    end
+
     context 'on a module with the authors "joev" and "blarg"' do
       let(:opts) { ({ 'author' => ['joev', 'blarg'] }) }
       accept = %w(author:joev author:joe)
@@ -260,6 +267,22 @@ def inverse_query_terms(search_string)
       it_should_behave_like 'search_filter', accept: accept, reject: reject
     end
 
+    context 'on a module with a #targets of ["ubuntu", "windows", "osx"]' do
+      let(:opts) { { 'targets' => %w[ubuntu windows osx] } }
+      accept = %w[targets:osx]
+      reject = %w[targets:unrelated]
+
+      it_should_behave_like 'search_filter', accept: accept, reject: reject
+    end
+
+    context 'on a module with a #targets of nil' do
+      let(:opts) { { 'targets' => nil } }
+
+      reject = %w[targets:foo]
+
+      it_should_behave_like 'search_filter', reject: reject
+    end
+
     context 'on a module that supports the osx platform' do
       let(:opts) { ({ 'platform' => 'osx' }) }
       accept = %w(platform:osx os:osx)
@@ -387,6 +410,14 @@ def inverse_query_terms(search_string)
       end
     end
 
+    context 'on a module with a #reference of nil' do
+      let(:opts) { { 'references' => nil } }
+
+      reject = %w[reference:foo]
+
+      it_should_behave_like 'search_filter', reject: reject
+    end
+
     REF_TYPES.each do |ref_type|
       ref_num = '1234-1111'
       context "on a module with reference #{ref_type}-#{ref_num}" do