Land #16666, Correctly format the notes sections

Author: gwillcox-r7

modules/auxiliary/admin/http/wp_automatic_plugin_privesc.rb

@@ -31,13 +31,13 @@ def initialize(info = {})
         'Targets' => [['WordPress', {}]],
         'DefaultTarget' => 0,
         'References' => [
-          ['URL', 'https://blog.nintechnet.com/critical-vulnerability-fixed-in-wordpress-automatic-plugin/'],
-          ['NOCVE', 'Patched in 3.53.3 without vendor disclosure']
+          ['URL', 'https://blog.nintechnet.com/critical-vulnerability-fixed-in-wordpress-automatic-plugin/']
         ],
         'Notes' => {
           'Stability' => [CRASH_SAFE],
           'Reliability' => [],
-          'SideEffects' => [CONFIG_CHANGES, IOC_IN_LOGS]
+          'SideEffects' => [CONFIG_CHANGES, IOC_IN_LOGS],
+          'NOCVE' => ['Patched in 3.53.3 without vendor disclosure']
         }
       )
     )

modules/auxiliary/admin/http/wp_gdpr_compliance_privesc.rb

@@ -35,7 +35,9 @@ def initialize(info = {})
         ],
       'Notes'           =>
         {
-          'SideEffects' =>  [CONFIG_CHANGES]
+          'Stability' => [],
+          'Reliability' => [],
+          'SideEffects' => [CONFIG_CHANGES]
         },
       'DisclosureDate'  => '2018-11-08'
     ))

modules/exploits/linux/misc/cisco_rv340_sslvpn.rb

@@ -62,10 +62,10 @@ def initialize(info = {})
         'DisclosureDate' => '2022-02-02',
         'DefaultTarget' => 0,
         'Notes' => {
-          'Stability' => CRASH_SERVICE_RESTARTS,
+          'Stability' => [CRASH_SERVICE_RESTARTS],
           # repeatable... but only works 65% of the time, see comments above
-          'Reliability' => REPEATABLE_SESSION,
-          'SideEffects' => nil
+          'Reliability' => [REPEATABLE_SESSION],
+          'SideEffects' => []
         }
       )
     )

modules/exploits/unix/webapp/bolt_authenticated_rce.rb

@@ -83,7 +83,7 @@ def initialize(info = {})
         },
         'DefaultTarget' => 2,
         'Notes' => {
-          'NOCVE' => '0day',
+          'NOCVE' => ['0day'],
           'Stability' => [SERVICE_RESOURCE_LOSS], # May hang up the service
           'Reliability' => [REPEATABLE_SESSION],
           'SideEffects' => [IOC_IN_LOGS, CONFIG_CHANGES, ARTIFACTS_ON_DISK]

modules/exploits/windows/browser/malwarebytes_update_exec.rb

@@ -35,7 +35,7 @@ def initialize(info = {})
       'References'     =>
         [
           [ 'CVE', '2014-4936' ],
-          [' OSVDB', '116050'],
+          [ 'OSVDB', '116050' ],
           [ 'URL', 'http://blog.0x3a.com/post/104954032239/cve-2014-4936-malwarebytes-anti-malware-and'] # Discoverer's blog
         ],
       'DefaultOptions' =>