is_name? returns false if value is ip address

sjanusz-r7 · sjanusz-r7 · commit 7f3cda843849 · 2025-07-16T18:25:18.000+01:00
diff --git a/lib/rex/socket.rb b/lib/rex/socket.rb
@@ -133,7 +133,7 @@ def self.support_ipv6?
   # Determine whether this is a valid DNS name without trying to resolve it
   #
   def self.is_name?(name)
-    return false if name.length > 253
+    return false if name.length > 253 || name =~ MATCH_IPV4 || name =~ MATCH_IPV6
     name.delete_suffix('.') =~ MATCH_DNS_NAME ? (name =~ /\s/).nil? : false
   end
 

Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,7 @@ def self.support_ipv6?`
`133`	`133`	`# Determine whether this is a valid DNS name without trying to resolve it`
`134`	`134`	`#`
`135`	`135`	`def self.is_name?(name)`
`136`		`- return false if name.length > 253`
	`136`	`+ return false if name.length > 253 \|\| name =~ MATCH_IPV4 \|\| name =~ MATCH_IPV6`
`137`	`137`	`name.delete_suffix('.') =~ MATCH_DNS_NAME ? (name =~ /\s/).nil? : false`
`138`	`138`	`end`
`139`	`139`