Run code_checks

Author: norkans7

ureport/polls/models.py

@@ -1170,9 +1170,7 @@ def calculate_results(self, segment=None):
                             .annotate(label=F("flow_result_category__category"), count=Sum("count"))
                             .values("label", "count")
                         )
-                        categories_results_dict = {
-                            elt["label"].lower(): elt["count"] for elt in categories_results
-                        }
+                        categories_results_dict = {elt["label"].lower(): elt["count"] for elt in categories_results}
 
                         unset_count_stats = (
                             PollStatsCounter.objects.filter(
@@ -1234,9 +1232,7 @@ def calculate_results(self, segment=None):
                             .annotate(label=F("flow_result_category__category"), count=Sum("count"))
                             .values("label", "count")
                         )
-                        categories_results_dict = {
-                            elt["label"].lower(): elt["count"] for elt in categories_results
-                        }
+                        categories_results_dict = {elt["label"].lower(): elt["count"] for elt in categories_results}
 
                         unset_count_stats = (
                             PollStatsCounter.objects.filter(
@@ -1285,9 +1281,7 @@ def calculate_results(self, segment=None):
                             .annotate(label=F("flow_result_category__category"), count=Sum("count"))
                             .values("label", "count")
                         )
-                        categories_results_dict = {
-                            elt["label"].lower(): elt["count"] for elt in categories_results
-                        }
+                        categories_results_dict = {elt["label"].lower(): elt["count"] for elt in categories_results}
                         categories = []
 
                         unset_count_stats = (

ureport/polls/tests.py

@@ -2204,8 +2204,6 @@ def test_squash_poll_stats_counters(self):
         age_segment_20 = AgeSegment.objects.filter(min_age=20).first()
         age_segment_25 = AgeSegment.objects.filter(min_age=25).first()
 
-        now = timezone.now().replace(hour=0, minute=0, second=0, microsecond=0)
-
         PollStatsCounter.objects.all().delete()
         self.assertEqual(0, PollStatsCounter.objects.all().count())
 
@@ -2444,7 +2442,6 @@ def test_squash_poll_stats_counters(self):
         self.assertEqual(11, PollStatsCounter.objects.all().count())
         self.assertEqual(poll_question1.calculate_results(segment=dict(age="Age")), calculated_results)
 
-
     def test_tasks(self):
         self.org = self.create_org("burundi", zoneinfo.ZoneInfo("Africa/Bujumbura"), self.admin)
 
@@ -2630,7 +2627,10 @@ def verify_counts():
             )
 
             activities = (
-                ContactActivity.objects.filter(org=self.nigeria).values("date").annotate(count__sum=Count("id")).order_by("date")
+                ContactActivity.objects.filter(org=self.nigeria)
+                .values("date")
+                .annotate(count__sum=Count("id"))
+                .order_by("date")
             )
             self.assertEqual(12, activity_counts.count())
             self.assertEqual(12, activities.count())

ureport/public/views.py

@@ -38,7 +38,7 @@
 from ureport.locations.models import Boundary
 from ureport.news.models import NewsItem
 from ureport.polls.models import Poll, PollQuestion
-from ureport.stats.models import GenderSegment, PollStatsCounter, PollEngagementDailyCount
+from ureport.stats.models import GenderSegment, PollEngagementDailyCount, PollStatsCounter
 from ureport.utils import (
     get_global_count,
     get_shared_countries_number,
@@ -488,7 +488,9 @@ def render_to_response(self, context, **kwargs):
                 segment_slug = results_params.get("segment")
                 time_filter = int(results_params.get("filter", "12"))
 
-                output_data = PollEngagementDailyCount.get_engagement_data(self.get_object(), metric, segment_slug, time_filter)
+                output_data = PollEngagementDailyCount.get_engagement_data(
+                    self.get_object(), metric, segment_slug, time_filter
+                )
         except json.JSONDecodeError:
             output_data = []
             pass
@@ -534,7 +536,8 @@ def get_context_data(self, **kwargs):
         context["average_response_rate"] = PollStatsCounter.get_average_response_rate(org)
 
         context["data_time_filters"] = [
-            dict(time_filter_number=key, label=str(val)) for key, val in PollEngagementDailyCount.DATA_TIME_FILTERS.items()
+            dict(time_filter_number=key, label=str(val))
+            for key, val in PollEngagementDailyCount.DATA_TIME_FILTERS.items()
         ]
 
         backend_options = org.backends.filter(is_active=True).values_list("slug", flat=True)
@@ -548,7 +551,9 @@ def get_context_data(self, **kwargs):
             if (key != "location" or show_maps)
         ]
 
-        context["data_metrics"] = [dict(slug=key, title=str(val)) for key, val in PollEngagementDailyCount.DATA_METRICS.items()]
+        context["data_metrics"] = [
+            dict(slug=key, title=str(val)) for key, val in PollEngagementDailyCount.DATA_METRICS.items()
+        ]
 
         context["hide_charts_breakdown"] = org.get_config("common.has_charts_hidden", False) and not (
             (user.is_authenticated and org in user.get_user_orgs()) or user.is_superuser

ureport/stats/models.py

@@ -401,7 +401,11 @@ def get_all_opinion_responses(cls, org, time_filter):
             .values(date=Cast("day", output_field=models.DateTimeField()))
             .annotate(Sum("count"))
         )
-        return [dict(name=str(_("Opinion Responses")), data=PollEngagementDailyCount.get_counts_data(responses, time_filter))]
+        return [
+            dict(
+                name=str(_("Opinion Responses")), data=PollEngagementDailyCount.get_counts_data(responses, time_filter)
+            )
+        ]
 
     @classmethod
     def get_gender_opinion_responses(cls, org, time_filter):
@@ -678,7 +682,9 @@ def get_scheme_response_rate_series(cls, org, time_filter):
                 .annotate(Sum("count"))
             )
 
-            gender_rate_series = PollEngagementDailyCount.get_response_rate_data(polled_stats, responded_stats, time_filter)
+            gender_rate_series = PollEngagementDailyCount.get_response_rate_data(
+                polled_stats, responded_stats, time_filter
+            )
 
             name = SchemeSegment.SCHEME_DISPLAY.get(scheme["scheme"], scheme["scheme"].upper())
             if not name:
@@ -728,7 +734,9 @@ def get_gender_response_rate_series(cls, org, time_filter):
                 .annotate(Sum("count"))
             )
 
-            gender_rate_series = PollEngagementDailyCount.get_response_rate_data(polled_stats, responded_stats, time_filter)
+            gender_rate_series = PollEngagementDailyCount.get_response_rate_data(
+                polled_stats, responded_stats, time_filter
+            )
             output_data.append(dict(name=org_gender_labels.get(gender["gender"]), data=gender_rate_series))
 
         return output_data
@@ -778,7 +786,9 @@ def get_age_response_rate_series(cls, org, time_filter):
                 .annotate(Sum("count"))
             )
 
-            age_rate_series = PollEngagementDailyCount.get_response_rate_data(polled_stats, responded_stats, time_filter)
+            age_rate_series = PollEngagementDailyCount.get_response_rate_data(
+                polled_stats, responded_stats, time_filter
+            )
             output_data.append(dict(name=data_key, data=age_rate_series))
         return output_data
 
@@ -811,8 +821,6 @@ def get_response_rate_data(cls, polled_qs, responded_qs, time_filter):
 
         return data
 
-
-
     class Meta:
         indexes = [
             models.Index(fields=["org", "flow_result"], name="stats_pedc_org_flowresult_idx"),

ureport/stats/tasks.py

@@ -16,7 +16,7 @@
 
 @org_task("refresh-engagement-data", 60 * 60 * 4)
 def refresh_engagement_data(org, since, until):
-    from .models import PollStatsCounter, PollEngagementDailyCount
+    from .models import PollEngagementDailyCount, PollStatsCounter
 
     start = time.time()
 

ureport/utils/__init__.py

@@ -915,7 +915,6 @@ def get_ureporters_locations_response_rates(org, segment):
         else:
             location_scopes.append(f"ward:{elt['osm_id'].upper()}")
 
-    boundaries_ids = [elt["id"] for elt in boundaries]
     polled_stats = (
         PollEngagementDailyCount.objects.filter(org=org, day__gte=year_ago, scope__in=location_scopes)
         .values("scope")