Fix boolean casting consistency with Pandas (#20746) #20747
+61
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #20746.
This PR fixes an inconsistency between cuDF and Pandas when casting floating-point columns containing
NaNvalues to boolean whilemode.pandas_compatibleis enabled.The Issue:
bool(float('nan'))evaluates toTrue. Casting a Series[1.0, NaN]to bool results in[True, True].NaNvalues in float columns were treated as nulls, which propagated as nulls after casting to bool ([True, <NA>]).The Fix:
Updated
as_numerical_columninnumerical.py. Whenmode.pandas_compatibleis on, if we detect a cast from Float -> Bool on a column with nulls, we explicitly fill the nulls withnp.nanbefore casting. This ensures the underlying cast logic evaluates them asTrue, matching Pandas behavior.Checklist
tests/test_issue_20746.py)