Skip to content

Fix plc.Scalar.from_py(datetime.datetime) incorrectly localizing naive datetimes #20769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2025
Merged

Fix plc.Scalar.from_py(datetime.datetime) incorrectly localizing naive datetimes #20769

merged 1 commit into from
Dec 2, 2025
+13 −1

Conversation

@mroeschke
Copy link
Contributor

@mroeschke mroeschke commented Dec 2, 2025

Description

closes pola-rs/polars#25549
closes #19044

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke self-assigned this Dec 2, 2025
@mroeschke mroeschke requested a review from a team as a code owner December 2, 2025 19:31
@mroeschke mroeschke added bug Something isn't working non-breaking Non-breaking change cudf-polars Issues specific to cudf-polars labels Dec 2, 2025
@mroeschke mroeschke added the pylibcudf Issues specific to the pylibcudf package label Dec 2, 2025
@github-actions github-actions bot added the Python Affects Python cuDF API. label Dec 2, 2025
@GPUtester GPUtester moved this to In Progress in cuDF Python Dec 2, 2025
@mroeschke mroeschke mentioned this pull request Dec 2, 2025
Open
2 tasks
@mroeschke
Copy link
Contributor Author

mroeschke commented Dec 2, 2025

/merge

@rapids-bot rapids-bot bot merged commit 027c2c2 into rapidsai:main Dec 2, 2025
140 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in cuDF Python Dec 2, 2025
@mroeschke mroeschke deleted the bug/pylibcudf/from_py_datetime branch December 2, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Matt711 Matt711 Matt711 approved these changes

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@rjzamora rjzamora Awaiting requested review from rjzamora rjzamora is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@mroeschke mroeschke

Labels

bug Something isn't working cudf-polars Issues specific to cudf-polars non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.

Projects

cuDF Python
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pl.datetime() result is incorrect while using the GPU engine [BUG] Avoid using un-timezoned datetimes in the test suite

2 participants

@mroeschke @Matt711