Skip to content

Conversation

@bdice
Copy link
Contributor

@bdice bdice commented Dec 2, 2025

Description

Upgrades nvcomp to version 5.1.0.21.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 2, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added the CMake CMake build issue label Dec 2, 2025
@bdice
Copy link
Contributor Author

bdice commented Dec 2, 2025

This depends on conda packages, which are not yet published.

@bdice bdice added DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 2, 2025
@github-actions github-actions bot added the Python Affects Python cuDF API. label Dec 2, 2025
@GPUtester GPUtester moved this to In Progress in cuDF Python Dec 2, 2025
@KyleFromNVIDIA
Copy link
Member

/ok to test 52198c7

@KyleFromNVIDIA
Copy link
Member

/ok to test f682b07

@KyleFromNVIDIA
Copy link
Member

/ok to test 6b816e2

@KyleFromNVIDIA
Copy link
Member

/ok to test 73213c7

@KyleFromNVIDIA
Copy link
Member

/ok to test e52b7d3

Comment on lines +7 to +8
set(rapids-cmake-repo "bdice/rapids-cmake")
set(rapids-cmake-branch "nvcomp-5.1")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this and merge immediately after rapidsai/rapids-cmake#946.

Suggested change
set(rapids-cmake-repo "bdice/rapids-cmake")
set(rapids-cmake-branch "nvcomp-5.1")

- build_cpp
- depends_on_libkvikio
- depends_on_librmm
- depends_on_libnvcomp
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetize this list. (I can't get a suggestion to work here for some reason.)

# (when nvcomp ships C++ wheels)
# https://github.com/rapidsai/build-planning/issues/171
# - depends_on_libnvcomp
- depends_on_libnvcomp
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CMake CMake build issue DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants