Require rapidsmpf Pool with the rapidsmpf runtime #20771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates our config to require using the rapidsmpf CUDA Stream Pool with the rapidsmpf runtime. As we move pieces of the IR execution into native rapidsmpf IR nodes (e.g. rapidsmpf's read_parquet), which necessarily have to occur on a stream from the rapidsmpf stream pool, it seems like the complexity of mixing multiple stream sources is not worth any potential benefits.
github-actions
bot
added
Python
TomAugspurger
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates our config to require using the rapidsmpf CUDA Stream Pool with the rapidsmpf runtime. As we move pieces of the IR execution into native rapidsmpf IR nodes (e.g. rapidsmpf's read_parquet), which necessarily have to occur on a stream from the rapidsmpf stream pool, it seems like the complexity of mixing multiple stream sources (mostly missing a necessary CUDA stream synchronization) is not worth any potential benefits.
Closes #20756