Skip to content

Commit 800e668

Browse files
authored
Merge branch 'main' into pre-commit-ci-update-config
2 parents 9eabcf0 + 145523d commit 800e668

File tree

10 files changed

+46
-22
lines changed

10 files changed

+46
-22
lines changed

.github/workflows/publish.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@ name: publish
44
on:
55
push:
66
branches:
7-
- "branch-*"
7+
- main
8+
- release/*
89
tags:
910
- v[0-9][0-9].[0-9][0-9].[0-9][0-9]
1011
workflow_dispatch:

.github/workflows/test-notebooks.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ jobs:
7171
steps:
7272
- name: Install required tools
7373
run: |
74-
mamba install -n base --freeze-installed \
74+
conda install -n base --freeze-installed \
7575
curl \
7676
git
7777
- name: Checkout code
@@ -94,7 +94,7 @@ jobs:
9494
- name: Install awscli
9595
if: '!cancelled()'
9696
run: |
97-
rapids-mamba-retry install -n base awscli
97+
rapids-conda-retry install -n base awscli
9898
- uses: aws-actions/configure-aws-credentials@v5
9999
if: '!cancelled()'
100100
with:

Dockerfile

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,8 @@ ARG LINUX_VER=notset
8383
ARG PYTHON_VER=notset
8484
ARG DEBIAN_FRONTEND=noninteractive
8585
ENV PATH=/opt/conda/bin:$PATH
86+
# ensure conda's files and configuration can be found at runtime even if environment activation was bypassed
87+
ENV CONDA_PREFIX=/opt/conda
8688
ENV PYTHON_VERSION=${PYTHON_VER}
8789

8890
SHELL ["/bin/bash", "-euo", "pipefail", "-c"]
@@ -174,7 +176,7 @@ PACKAGES_TO_INSTALL=(
174176
'ipython>=8.37.0'
175177
'rapids-cli==0.1.*'
176178
)
177-
rapids-mamba-retry install -y -n base \
179+
rapids-conda-retry install -y -n base \
178180
"${PACKAGES_TO_INSTALL[@]}"
179181

180182
conda clean -afy
@@ -204,7 +206,7 @@ COPY --from=dependencies --chown=rapids /test_notebooks_dependencies.yaml test_n
204206
COPY --from=dependencies --chown=rapids /notebooks /home/rapids/notebooks
205207

206208
RUN <<EOF
207-
rapids-mamba-retry env update -n base -f test_notebooks_dependencies.yaml
209+
rapids-conda-retry env update -n base -f test_notebooks_dependencies.yaml
208210
conda clean -afy
209211
EOF
210212

@@ -214,7 +216,7 @@ PACKAGES_TO_INSTALL=(
214216
'dask-labextension>=7.0.0'
215217
'jupyterlab-nvdashboard>=0.13.0'
216218
)
217-
rapids-mamba-retry install -y -n base \
219+
rapids-conda-retry install -y -n base \
218220
"${PACKAGES_TO_INSTALL[@]}"
219221
conda clean -afy
220222
EOF

context/entrypoint.sh

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
#!/usr/bin/env bash
2-
# Copyright (c) 2023-2025, NVIDIA CORPORATION.
1+
#!/usr/bin/env -S bash -l
2+
# Copyright (c) 2023-2026, NVIDIA CORPORATION.
33

44
set -eo pipefail
55

@@ -10,14 +10,17 @@ https://developer.download.nvidia.com/licenses/NVIDIA_Deep_Learning_Container_Li
1010
1111
EOF
1212

13+
# Activate conda (login shell sources from /etc/profile.d/conda.sh)
14+
conda activate
15+
1316
if [ -e "/home/rapids/environment.yml" ]; then
1417
echo "environment.yml found. Installing packages."
15-
timeout ${CONDA_TIMEOUT:-600} mamba env update -n base -y -f /home/rapids/environment.yml || exit $?
18+
timeout ${CONDA_TIMEOUT:-600} conda env update -n base -y -f /home/rapids/environment.yml || exit $?
1619
fi
1720

1821
if [ "$EXTRA_CONDA_PACKAGES" ]; then
1922
echo "EXTRA_CONDA_PACKAGES environment variable found. Installing packages."
20-
timeout ${CONDA_TIMEOUT:-600} mamba install -n base -y $EXTRA_CONDA_PACKAGES || exit $?
23+
timeout ${CONDA_TIMEOUT:-600} conda install -n base -y $EXTRA_CONDA_PACKAGES || exit $?
2124
fi
2225

2326
if [ "$EXTRA_PIP_PACKAGES" ]; then

context/scripts/configure-conda-base-environment

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#!/bin/bash
2+
# Copyright (c) 2026, NVIDIA CORPORATION.
23

34
# [description]
45
#
@@ -33,8 +34,8 @@ if [[ "$PYTHON_VERSION_PADDED" > "3.12" ]]; then
3334
else
3435
PYTHON_ABI_TAG="cpython"
3536
fi
36-
rapids-mamba-retry install -y -n base "python>=${PYTHON_VERSION},<${PYTHON_UPPER_BOUND}=*_${PYTHON_ABI_TAG}"
37-
rapids-mamba-retry update --all -y -n base
37+
rapids-conda-retry install -y -n base "python>=${PYTHON_VERSION},<${PYTHON_UPPER_BOUND}=*_${PYTHON_ABI_TAG}"
38+
rapids-conda-retry update --all -y -n base
3839
find /opt/conda -follow -type f -name '*.a' -delete
3940
find /opt/conda -follow -type f -name '*.pyc' -delete
4041

context/scripts/update-base-conda-environment

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#!/bin/bash
2+
# Copyright (c) 2026, NVIDIA CORPORATION.
23

34
set -e -u -o pipefail
45

@@ -14,7 +15,7 @@ SCRIPT_DIR="$(dirname "$(realpath "${BASH_SOURCE[0]}")")"
1415
# Ensure new files/dirs have group write permissions
1516
umask 002
1617

17-
# install gha-tools for rapids-mamba-retry
18+
# install gha-tools for rapids-conda-retry
1819
"${SCRIPT_DIR}/install-gha-tools"
1920

2021
# Example of pinned package in case you require an override
@@ -23,7 +24,7 @@ umask 002
2324
# update everything before other environment changes, to ensure mixing
2425
# an older conda with newer packages still works well
2526
PATH="/opt/conda/bin:$PATH" \
26-
rapids-mamba-retry update --all -y -n base
27+
rapids-conda-retry update --all -y -n base
2728

2829
# clean up the package cache and other unused files, to minimize
2930
# what's copied into later images

cuvs-bench/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ These images are meant to enable end users of cuVS ANN algorithms to easily run
99
There are two image types:
1010

1111
- gpu: Contains dockerfile to build images using conda packages for GPU systems.
12-
- cpu: Contains dockerfile to build images using conda packages for CPU systems. Based on `mambaforge`.
12+
- cpu: Contains dockerfile to build images using conda packages for CPU systems. Based on `miniforge`.
1313

1414
# Running the Containers
1515

cuvs-bench/cpu/Dockerfile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ RUN \
3434
apt-get install -y --no-install-recommends \
3535
"${PACKAGES_TO_INSTALL[@]}"
3636

37-
# install gha-tools for rapids-mamba-retry
37+
# install gha-tools for rapids-conda-retry
3838
/tmp/build-scripts/install-gha-tools
3939

4040
# clean up
@@ -45,14 +45,14 @@ EOF
4545
# an older conda with newer packages still works well
4646
# ref: https://github.com/rapidsai/ci-imgs/issues/185
4747
RUN <<EOF
48-
rapids-mamba-retry update --all -y -n base
49-
rapids-mamba-retry install -y -n base "python=${PYTHON_VER}"
50-
rapids-mamba-retry update --all -y -n base
48+
rapids-conda-retry update --all -y -n base
49+
rapids-conda-retry install -y -n base "python=${PYTHON_VER}"
50+
rapids-conda-retry update --all -y -n base
5151
PACKAGES_TO_INSTALL=(
5252
"cuvs-bench-cpu=${RAPIDS_VER}.*"
5353
"python=${PYTHON_VER}"
5454
)
55-
rapids-mamba-retry install -y -n base \
55+
rapids-conda-retry install -y -n base \
5656
"${PACKAGES_TO_INSTALL[@]}"
5757
conda clean -afy
5858
chmod -R 777 /opt/conda

cuvs-bench/gpu/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,12 +91,12 @@ rm -rf /var/lib/apt/lists/*
9191
/tmp/build-scripts/install-gha-tools
9292

9393
# install cuvs-bench
94-
rapids-mamba-retry update --all -y -n base
94+
rapids-conda-retry update --all -y -n base
9595
PACKAGES_TO_INSTALL=(
9696
"cuvs-bench=${RAPIDS_VER}.*"
9797
"cuda-version=${CUDA_VER%.*}.*"
9898
)
99-
rapids-mamba-retry install -y -n base \
99+
rapids-conda-retry install -y -n base \
100100
"${PACKAGES_TO_INSTALL[@]}"
101101
conda clean -afy
102102
chmod -R 777 /opt/conda

tests/container-canary/base.yml

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,14 @@ checks:
2929
- -c
3030
# the second component could have a 't' for like '3.15t' for free-threaded builds at some point in the future
3131
- '[[ "${PYTHON_VERSION}" =~ ^[0-9]{1,2}\.[0-9t]{1,2}$ ]]'
32+
- name: tst-conda-active
33+
description: test the conda environment is active if running with a login shell
34+
probe:
35+
exec:
36+
command:
37+
- /bin/bash
38+
- -lc
39+
- '[ "${CONDA_EXE+x}" ];'
3240
- name: tool-conda
3341
description: conda can be executed
3442
probe:
@@ -124,3 +132,11 @@ checks:
124132
- /bin/bash
125133
- -c
126134
- "[[ $(conda env list --quiet | grep --count -E '^[A-Za-z]+') == 1 ]];"
135+
- name: conda-prefix
136+
description: Conda prefix set to /opt/conda
137+
probe:
138+
exec:
139+
command:
140+
- /bin/bash
141+
- -c
142+
- '[[ "${CONDA_PREFIX}" == "/opt/conda" ]];'

0 commit comments

Comments
 (0)