Skip to content

Commit edcacd1

Browse files
authored
avoid interactive prompts when updating from an environment.yaml (#727)
Working with @taureandyernv yesterday, we tried something like this to patch in a dependency at run time. ```shell cat > ./environment.yml <<EOF channels: - dglteam/label/th23_cu121 dependencies: - dgl EOF docker run \ --rm \ -v $(pwd)/environment.yml:/home/rapids/environment.yml \ -it rapidsai/base:25.02a-cuda12.5-py3.12 \ conda env export ``` Found that that prompts for confirmation: ```text Package Version Build Channel Size ────────────────────────────────────────────────────────────────────────── Install: ────────────────────────────────────────────────────────────────────────── + dgl 2.4.0.th23.cu121 py312_0 dglteam/label/th23_cu121 295MB Summary: Install: 1 packages Total download: 295MB ────────────────────────────────────────────────────────────────────────── Confirm changes: [Y/n] ``` But that prompt seems not to make it through to `mamba`. And even if that did work, this interactive prompt prevents the use of the "mount in an `environment.yml`" approach in situations where you aren't running the container interactively... for example, where you want to use this image in a container in a Kubernetes Pod, and provide an `environment.yml` via a ConfigMap or file Secret. This proposes skipping the confirmation and always running `mamba env update -y` when an `environment.yml` is provided. ## Notes for Reviewers ### How I tested this Pulled an image built from this PR and confirmed that that install pattern described above works and does not prompt for interactive input. ```shell cat > ./environment.yml <<EOF channels: - dglteam/label/th23_cu121 dependencies: - dgl EOF docker run \ --rm \ -v $(pwd)/environment.yml:/home/rapids/environment.yml \ -it rapidsai/staging:docker-727-25.02a-cuda12.5-py3.12 \ conda env export ``` ```text ... - dgl=2.4.0.th23.cu121=py312_0 ... ``` Authors: - James Lamb (https://github.com/jameslamb) - Bradley Dice (https://github.com/bdice) Approvers: - Bradley Dice (https://github.com/bdice) URL: #727
1 parent 3f8cea7 commit edcacd1

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

context/entrypoint.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ EOF
1010

1111
if [ -e "/home/rapids/environment.yml" ]; then
1212
echo "environment.yml found. Installing packages."
13-
timeout ${CONDA_TIMEOUT:-600} mamba env update -n base -f /home/rapids/environment.yml || exit $?
13+
timeout ${CONDA_TIMEOUT:-600} mamba env update -n base -y -f /home/rapids/environment.yml || exit $?
1414
fi
1515

1616
if [ "$EXTRA_CONDA_PACKAGES" ]; then

context/test_notebooks.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
'cuspatial/nyc_taxi_years_correlation.ipynb',
3434
# context on skip zipcodes: https://github.com/rapidsai/cuspatial/issues/1426
3535
'cuspatial/ZipCodes_Stops_PiP_cuSpatial.ipynb',
36-
# context on this being skipped: https://github.com/rapidsai/docker/pull/728#issuecomment-2631146036
36+
# context on this being skipped: https://github.com/rapidsai/docker/issues/726
3737
'cuspatial/trajectory_clustering.ipynb',
3838
]
3939

0 commit comments

Comments
 (0)