Make get_property constexpr across tests, benchmarks, and thrust_allocator_adaptor

Author: bdice

cpp/benchmarks/utilities/simulated_memory_resource.hpp

@@ -112,8 +112,8 @@ class simulated_memory_resource final {
   bool operator==(simulated_memory_resource const&) const noexcept { return true; }
   bool operator!=(simulated_memory_resource const&) const noexcept { return false; }
 
-  RMM_CONSTEXPR_FRIEND void get_property(simulated_memory_resource const&,
-                                         cuda::mr::device_accessible) noexcept
+  constexpr friend void get_property(simulated_memory_resource const&,
+                                     cuda::mr::device_accessible) noexcept
   {
   }
 

cpp/include/rmm/mr/thrust_allocator_adaptor.hpp

@@ -133,7 +133,10 @@ class thrust_allocator : public thrust::device_malloc_allocator<T> {
    *
    * This property declares that a `thrust_allocator` provides device accessible memory
    */
-  friend void get_property(thrust_allocator const&, cuda::mr::device_accessible) noexcept {}
+  RMM_CONSTEXPR_FRIEND void get_property(thrust_allocator const&,
+                                         cuda::mr::device_accessible) noexcept
+  {
+  }
 
  private:
   cuda_stream_view _stream{};

cpp/tests/device_check_resource_adaptor.hpp

@@ -79,8 +79,8 @@ class device_check_resource_adaptor final {
     return !(*this == other);
   }
 
-  friend void get_property(device_check_resource_adaptor const&,
-                           cuda::mr::device_accessible) noexcept
+  constexpr friend void get_property(device_check_resource_adaptor const&,
+                                     cuda::mr::device_accessible) noexcept
   {
   }
 

cpp/tests/mock_resource.hpp

@@ -35,7 +35,7 @@ class mock_resource {
 
   bool operator==(mock_resource const&) const noexcept { return true; }
   bool operator!=(mock_resource const&) const { return false; }
-  friend void get_property(mock_resource const&, cuda::mr::device_accessible) noexcept {}
+  constexpr friend void get_property(mock_resource const&, cuda::mr::device_accessible) noexcept {}
   using size_pair = std::pair<std::size_t, std::size_t>;
 };
 
@@ -80,7 +80,10 @@ class mock_resource_wrapper {
   }
   bool operator!=(mock_resource_wrapper const& other) const noexcept { return !(*this == other); }
 
-  friend void get_property(mock_resource_wrapper const&, cuda::mr::device_accessible) noexcept {}
+  constexpr friend void get_property(mock_resource_wrapper const&,
+                                     cuda::mr::device_accessible) noexcept
+  {
+  }
 
  private:
   mock_resource* mock_;

cpp/tests/mr/arena_mr_tests.cpp

@@ -39,7 +39,10 @@ class mock_memory_resource {
 
   bool operator==(mock_memory_resource const&) const noexcept { return true; }
   bool operator!=(mock_memory_resource const&) const { return false; }
-  friend void get_property(mock_memory_resource const&, cuda::mr::device_accessible) noexcept {}
+  constexpr friend void get_property(mock_memory_resource const&,
+                                     cuda::mr::device_accessible) noexcept
+  {
+  }
 };
 
 // static property checks
@@ -84,8 +87,8 @@ class mock_memory_resource_wrapper {
     return !(*this == other);
   }
 
-  friend void get_property(mock_memory_resource_wrapper const&,
-                           cuda::mr::device_accessible) noexcept
+  constexpr friend void get_property(mock_memory_resource_wrapper const&,
+                                     cuda::mr::device_accessible) noexcept
   {
   }
 

cpp/tests/mr/delayed_memory_resource.hpp

@@ -48,7 +48,10 @@ class delayed_memory_resource {
     upstream_.deallocate(stream, ptr, bytes, alignment);
     std::this_thread::sleep_for(delay_);
   }
-  friend void get_property(delayed_memory_resource const&, cuda::mr::device_accessible) noexcept {}
+  constexpr friend void get_property(delayed_memory_resource const&,
+                                     cuda::mr::device_accessible) noexcept
+  {
+  }
   bool operator==(delayed_memory_resource const& other) const noexcept
   {
     return this == std::addressof(other);

cpp/tests/mr/failure_callback_mr_tests.cpp

@@ -62,8 +62,8 @@ class always_throw_memory_resource final {
 
   bool operator==(always_throw_memory_resource const&) const noexcept { return true; }
   bool operator!=(always_throw_memory_resource const&) const noexcept { return false; }
-  friend void get_property(always_throw_memory_resource const&,
-                           cuda::mr::device_accessible) noexcept
+  constexpr friend void get_property(always_throw_memory_resource const&,
+                                     cuda::mr::device_accessible) noexcept
   {
   }
 };

cpp/tests/mr/resource_ref_conversion_tests.cpp

@@ -54,7 +54,10 @@ class new_delete_memory_resource {
   bool operator!=(new_delete_memory_resource const& other) const { return !operator==(other); }
 
   // NOLINTBEGIN
-  friend void get_property(new_delete_memory_resource const&, cuda::mr::host_accessible) noexcept {}
+  constexpr friend void get_property(new_delete_memory_resource const&,
+                                     cuda::mr::host_accessible) noexcept
+  {
+  }
   // NOLINTEND
 };