Skip to content

Commit 58388ff

Browse files
committed
Turns out that fix won't help with the PMA issues in MacOS CI
targets. /etc/pam.d is a protected directory and you need some sort of user intervention to grant permission to allow the terminal to make these changes. This is in addition to using sudo. As of now we'll need to use self hosted runners to make this happen. What's interesting is that it pam.d doesn't fail under the ubuntu tests. For some reason it's either not actually testing pam or it's using the sshd control file. It would be nice if the behaviour was predictable
1 parent a1bda23 commit 58388ff

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

.github/setup_ci.sh

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ esac
2626
TARGETS=$@
2727

2828
INSTALL_FIDO_PPA="no"
29-
COPY_PAM_MODULE="no"
29+
#COPY_PAM_MODULE="no"
3030
export DEBIAN_FRONTEND=noninteractive
3131

3232
#echo "Setting up for '$TARGETS'"
@@ -86,7 +86,7 @@ for TARGET in $TARGETS; do
8686
esac
8787
;;
8888
*pam)
89-
COPY_PAM_MODULE="yes"
89+
# COPY_PAM_MODULE="yes"
9090
PACKAGES="$PACKAGES libpam0g-dev"
9191
;;
9292
sk)
@@ -143,11 +143,11 @@ fi
143143

144144
#need to copy the pam modules for sshd to hpnsshd on
145145
#macos with pam.
146-
if [ "yes" = "$COPY_PAM_MODULE" ]; then
147-
if [ `uname` = "Darwin" }; then
148-
sudo cp /etc/pam.d/sshd /etc/pam.d/hpnsshd
149-
fi
150-
fi
146+
#if [ "yes" = "$COPY_PAM_MODULE" ]; then
147+
# if [ `uname` = "Darwin" }; then
148+
# sudo cp /etc/pam.d/sshd /etc/pam.d/hpnsshd
149+
# fi
150+
#fi
151151

152152
tries=3
153153
while [ ! -z "$PACKAGES" ] && [ "$tries" -gt "0" ]; do

0 commit comments

Comments
 (0)