Skip to content

Commit 90127cd

Browse files
committed
binn.[c|h] are no lnoger C89 compliant so we are removing the C89 test from the
CI workflow. I don't think this will be a major issue with our projected audience. Additionally, in binn.c instances of BOOL value; needed to be defined or the -Werror tests failed. Likewise, I need to move the position of a /*fall through*/ in binn.c
1 parent 44937cd commit 90127cd

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

binn.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -950,8 +950,8 @@ BINN_PRIVATE BOOL AddValue(binn *item, int type, void *pvalue, int size) {
950950
break;
951951
case BINN_STORAGE_BLOB:
952952
case BINN_STORAGE_STRING:
953-
/* fall through */
954953
if (size == 0) break; // the 2 above are allowed to have 0 length
954+
/* fall through */
955955
default:
956956
return FALSE;
957957
}
@@ -2804,7 +2804,7 @@ double APIENTRY binn_list_double(const void *list, int pos) {
28042804
}
28052805

28062806
BOOL APIENTRY binn_list_bool(const void *list, int pos) {
2807-
BOOL value;
2807+
BOOL value = TRUE;
28082808

28092809
binn_list_get(list, pos, BINN_BOOL, &value, NULL);
28102810

@@ -2940,7 +2940,7 @@ double APIENTRY binn_map_double(const void *map, int id) {
29402940
}
29412941

29422942
BOOL APIENTRY binn_map_bool(const void *map, int id) {
2943-
BOOL value;
2943+
BOOL value = TRUE;
29442944

29452945
binn_map_get(map, id, BINN_BOOL, &value, NULL);
29462946

@@ -3076,7 +3076,7 @@ double APIENTRY binn_object_double(const void *obj, const char *key) {
30763076
}
30773077

30783078
BOOL APIENTRY binn_object_bool(const void *obj, const char *key) {
3079-
BOOL value;
3079+
BOOL value = TRUE;
30803080

30813081
binn_object_get(obj, key, BINN_BOOL, &value, NULL);
30823082

0 commit comments

Comments
 (0)