Skip to content

Commit ba9c2f1

Browse files
committed
Updated method to skip none MAC regression test.
It's easier and less error prone to just filter the none MAC from the list of MACs to test.
1 parent b0050bd commit ba9c2f1

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

regress/rekey.sh

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,14 @@ opts=""
7575
# Filter out duplicate curve algo
7676
kexs=`${SSH} -Q kex | grep -v [email protected]`
7777
ciphers=`${SSH} -Q cipher`
78-
macs=`${SSH} -Q mac`
78+
79+
# HPN-SSH enables the none MAC but this fails
80+
# in the regression tests because, by default,
81+
# we don't enable the none MAC so the test
82+
# will fail. As such, we skip it by
83+
# filtering it out.
84+
# CJR 9/30/2024
85+
macs=`${SSH} -Q mac | grep -v none`
7986

8087
for i in $kexs; do
8188
opts="$opts KexAlgorithms=$i"
@@ -88,14 +95,6 @@ for i in $macs; do
8895
done
8996

9097
for opt in $opts; do
91-
# HPN-SSH enables the none MAC but this fails
92-
# in the regression tests because, by default,
93-
# we don't enable the none MAC so the test
94-
# will fail. As such, skip it.
95-
# CJR 9/30/2024
96-
if echo ${opt} | grep -Eq "none"; then
97-
continue
98-
fi
9998
verbose "client rekey $opt"
10099
if ${SSH} -Q cipher-auth | sed 's/^/Ciphers=/' | \
101100
grep $opt >/dev/null; then

0 commit comments

Comments
 (0)