Fix - Avoid running duplicate unit test on each testcase

Author: vigneshgurusamy

tests/Adapters/KapAdapterTest.php

@@ -19,15 +19,6 @@ protected function getEnvironmentSetUp($app)
         ]);
     }
 
-    /**
-     * {@inheritdoc}
-     */
-    public function setUp()
-    {
-        parent::setUp();
-        $this->manager = Sms::app(Sms::KapAdapter());
-    }
-
     /**
      * @test
      * @expectedException Linkstreet\LaravelSms\Exceptions\AdapterException
@@ -90,8 +81,8 @@ public function sendSms()
         $stub->setClient(new \GuzzleHttp\Client(['handler' => \GuzzleHttp\HandlerStack::create($mock)]));
 
         $response = Sms::app($stub)
-            ->to($this->devices)
-            ->send($this->message);
+            ->to(Sms::DeviceCollection([Sms::Device('+910000000001'), Sms::Device('00000')]))
+            ->send(Sms::Message('Hello world'));
 
         $this->assertEquals(200, $response->getStatusCode());
         $this->assertTrue((bool) $response->getSuccessCount());

tests/CoreTest.php

@@ -0,0 +1,40 @@
+<?php
+
+namespace Linkstreet\LaravelSms\Tests;
+
+use Sms;
+
+class CoreTest extends TestCase
+{
+    /**
+     * Test the device model
+     */
+    public function testDevice()
+    {
+        $device = Sms::Device('+910000000000');
+        $this->assertSame('+910000000001', $device->setNumber('+910000000001')->getNumber());
+    }
+
+    /**
+     * Test the device collection & device
+     */
+    public function testDeviceCollection()
+    {
+        $number1 = '+910000000001';
+        $number2 = '+910000000002';
+        $devices = Sms::DeviceCollection([Sms::Device($number1), Sms::Device($number2)]);
+
+        $this->assertSame(2, $devices->count());
+        $this->assertSame($number1, $devices->get($number1)->getNumber());
+        $this->assertSame($number2, $devices->get($number2)->getNumber());
+    }
+
+    /**
+     * Test the message model
+     */
+    public function testMessage()
+    {
+        $message = Sms::Message('Hello world');
+        $this->assertSame('Hello world!', $message->setMessage('Hello world!')->getMessage());
+    }
+}

tests/TestCase.php

@@ -2,16 +2,8 @@
 
 namespace Linkstreet\LaravelSms\Tests;
 
-use Sms;
-
 abstract class TestCase extends \Orchestra\Testbench\TestCase
 {
-    public $device;
-
-    public $devices;
-
-    public $message;
-
     /**
      * {@inheritdoc}
      */
@@ -29,47 +21,4 @@ protected function getPackageAliases($app)
             'Sms' => 'Linkstreet\LaravelSms\Facades\Sms'
         ];
     }
-
-    /**
-     * {@inheritdoc}
-     */
-    public function setUp()
-    {
-        parent::setUp();
-        $this->device = Sms::Device('+910000000000');
-        $this->testDevice();
-        $this->devices = Sms::DeviceCollection([$this->device, Sms::Device('00000')]);
-        $this->testDeviceCollection();
-        $this->message = Sms::Message('Hello world');
-        $this->testMessage();
-    }
-
-    /**
-     * Test the device model
-     */
-    public function testDevice()
-    {
-        $this->assertSame('+910000000001', $this->device->setNumber('+910000000001')->getNumber());
-    }
-
-    /**
-     * Test the device collection & device
-     */
-    public function testDeviceCollection()
-    {
-        $count = 0;
-        foreach ($this->devices as $device) {
-            $count++;
-        }
-        $this->assertSame($count, $this->devices->count());
-        $this->assertSame($this->device, $this->devices->get('+910000000001'));
-    }
-
-    /**
-     * Test the message model
-     */
-    public function testMessage()
-    {
-        $this->assertSame('Hello world!', $this->message->setMessage('Hello world!')->getMessage());
-    }
 }