Skip to content

Commit 5d27186

Browse files
lrljoegithub-actions[bot]
authored andcommitted
Fix styling
1 parent ce515bd commit 5d27186

File tree

8 files changed

+17
-31
lines changed

8 files changed

+17
-31
lines changed

src/Traits/Configuration/FilterConfiguration.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ public function setFilterPillsDisabled(): self
6969
return $this;
7070
}
7171

72-
7372
public function generateFilterGenericData(): array
7473
{
7574
return (new FilterGenericData($this->getTableName(), $this->getFilterLayout(), $this->isTailwind(), $this->isBootstrap4(), $this->isBootstrap5()))->toArray();

src/Traits/Helpers/FilterHelpers.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,6 @@ public function getVisibleFilters(): Collection
266266
return $this->getFilters()->reject(fn (Filter $filter) => $filter->isHiddenFromMenus());
267267
}
268268

269-
270269
public function hasFilterGenericData(): bool
271270
{
272271
return ! empty($this->filterGenericData);

src/Traits/Styling/Configuration/FilterMenuStylingConfiguration.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,5 +61,4 @@ public function setFilterSlideDownDefaultStatusEnabled(): self
6161

6262
return $this;
6363
}
64-
65-
}
64+
}

src/Traits/Styling/HasFilterMenuStyling.php

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@
33
namespace Rappasoft\LaravelLivewireTables\Traits\Styling;
44

55
use Livewire\Attributes\Locked;
6-
use Rappasoft\LaravelLivewireTables\Traits\Styling\Helpers\FilterMenuStylingHelpers;
76
use Rappasoft\LaravelLivewireTables\Traits\Styling\Configuration\FilterMenuStylingConfiguration;
7+
use Rappasoft\LaravelLivewireTables\Traits\Styling\Helpers\FilterMenuStylingHelpers;
88

99
trait HasFilterMenuStyling
1010
{
1111
use FilterMenuStylingConfiguration,
12-
FilterMenuStylingHelpers;
12+
FilterMenuStylingHelpers;
1313

1414
#[Locked]
1515
public string $filterLayout = 'popover';
@@ -18,8 +18,4 @@ trait HasFilterMenuStyling
1818
public bool $filterSlideDownDefaultVisible = false;
1919

2020
protected array $filterPopoverAttributes = ['class' => '', 'default-width' => true, 'default-colors' => true, 'default-styling' => true];
21-
22-
23-
24-
2521
}

src/Traits/Styling/Helpers/FilterMenuStylingHelpers.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ public function isFilterLayoutSlideDown(): bool
4848
return $this->getFilterLayout() === 'slide-down';
4949
}
5050

51-
5251
/**
5352
* Get whether any filter has a configured slide down row.
5453
*/
@@ -90,5 +89,4 @@ public function getFiltersByRow(): array
9089

9190
return $orderedFilters;
9291
}
93-
94-
}
92+
}

src/Traits/WithFilters.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ trait WithFilters
1717
FilterHelpers;
1818
use HasQueryStringForFilter;
1919
use HasFilterMenuStyling;
20-
20+
2121
#[Locked]
2222
public bool $filtersStatus = true;
2323

tests/Unit/Traits/Styling/FilterPopoverStylingTest.php

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
final class FilterPopoverStylingTest extends TestCase
88
{
9-
109
public function test_filter_popover_attributes_returns_default_if_not_set(): void
1110
{
1211
$this->assertSame(['class' => '', 'default-width' => true, 'default-colors' => true, 'default-styling' => true], $this->basicTable->getFilterPopoverAttributes());
@@ -25,7 +24,4 @@ public function test_filter_popover_attributes_can_be_changed(): void
2524
$this->assertSame(['class' => 'bg-red-500', 'default-width' => true, 'default-colors' => false, 'default-styling' => true], $this->basicTable->getFilterPopoverAttributes());
2625

2726
}
28-
29-
30-
31-
}
27+
}

tests/Unit/Traits/Visuals/FilterVisualsTest.php

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,6 @@ public function configure(): void
169169
{
170170
$this->setPrimaryKey('id');
171171

172-
173172
}
174173

175174
public function filters(): array
@@ -208,17 +207,17 @@ public function filters(): array
208207
];
209208
}
210209
})
211-
->assertSeeHtmlInOrder([
212-
'class="w-full md:w-56 origin-top-left absolute left-0 mt-2 rounded-md shadow-lg ring-1 ring-opacity-5 divide-y focus:outline-none z-50 bg-white divide-gray-100 ring-black dark:bg-gray-700 dark:text-white dark:divide-gray-600"',
213-
])
214-
->call('setFilterPopoverAttributes', ['class' => 'w-96', 'default-width' => false])
215-
->assertSeeHtmlInOrder([
216-
'class="origin-top-left absolute left-0 mt-2 rounded-md shadow-lg ring-1 ring-opacity-5 divide-y focus:outline-none z-50 bg-white divide-gray-100 ring-black dark:bg-gray-700 dark:text-white dark:divide-gray-600 w-96"',
217-
])
218-
->call('setFilterPopoverAttributes', ['class' => 'w-96', 'default-width' => false, 'default-colors' => false])
219-
->assertSeeHtmlInOrder([
220-
'class="origin-top-left absolute left-0 mt-2 rounded-md shadow-lg ring-1 ring-opacity-5 divide-y focus:outline-none z-50 w-96"',
221-
]);
210+
->assertSeeHtmlInOrder([
211+
'class="w-full md:w-56 origin-top-left absolute left-0 mt-2 rounded-md shadow-lg ring-1 ring-opacity-5 divide-y focus:outline-none z-50 bg-white divide-gray-100 ring-black dark:bg-gray-700 dark:text-white dark:divide-gray-600"',
212+
])
213+
->call('setFilterPopoverAttributes', ['class' => 'w-96', 'default-width' => false])
214+
->assertSeeHtmlInOrder([
215+
'class="origin-top-left absolute left-0 mt-2 rounded-md shadow-lg ring-1 ring-opacity-5 divide-y focus:outline-none z-50 bg-white divide-gray-100 ring-black dark:bg-gray-700 dark:text-white dark:divide-gray-600 w-96"',
216+
])
217+
->call('setFilterPopoverAttributes', ['class' => 'w-96', 'default-width' => false, 'default-colors' => false])
218+
->assertSeeHtmlInOrder([
219+
'class="origin-top-left absolute left-0 mt-2 rounded-md shadow-lg ring-1 ring-opacity-5 divide-y focus:outline-none z-50 w-96"',
220+
]);
222221

223222
}
224223

0 commit comments

Comments
 (0)