Skip to content

Commit 605db7d

Browse files
author
Florian Stascheck
authored
Column::make: return type static
`LinkColumn::make()->title()` gives currently an error in PHPStan in my project because it expects `LinkColumn::make` to return a `Column` even though it returns a `LinkColumn`. I saw in your composer.json file that you also maintain compatability with 7.4, so I only changed the return type in the doc block. Ideal would of course be to also have `static` as return type also in the code itself.
1 parent 60d60c2 commit 605db7d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/Views/Column.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ public function __construct(string $title, string $from = null)
8484
* @param string $title
8585
* @param string|null $from
8686
*
87-
* @return Column
87+
* @return static
8888
*/
8989
public static function make(string $title, string $from = null): Column
9090
{

0 commit comments

Comments
 (0)