Skip to content

Commit de31c79

Browse files
committed
Changes
- Change param to query - Fix psalm errors
1 parent cffd2ef commit de31c79

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

src/DataTableComponent.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -194,11 +194,11 @@ public function render()
194194
/**
195195
* Get a column object by its field
196196
*
197-
* @param $column
197+
* @param string $column
198198
*
199199
* @return mixed
200200
*/
201-
protected function getColumn($column)
201+
protected function getColumn(string $column)
202202
{
203203
return collect($this->columns())
204204
->where('column', $column)

src/Traits/WithSorting.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public function applySorting(Builder $query): Builder
3131
{
3232
foreach ($this->sorts as $field => $direction) {
3333
if (optional($this->getColumn($field))->hasSortCallback()) {
34-
$query = app()->call($this->getColumn($field)->getSortCallback(), ['builder' => $query, 'direction' => $direction]);
34+
$query = app()->call($this->getColumn($field)->getSortCallback(), ['query' => $query, 'direction' => $direction]);
3535
} else {
3636
$query->orderBy($field, $direction);
3737
}

src/Views/Column.php

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class Column
2525
public bool $sortable = false;
2626

2727
/**
28-
* @var null
28+
* @var
2929
*/
3030
public $sortCallback;
3131

@@ -108,13 +108,11 @@ public function isBlank(): bool
108108
/**
109109
* @return $this
110110
*/
111-
public function sortable(callable $callback = null): self
111+
public function sortable($callback = null): self
112112
{
113113
$this->sortable = true;
114114

115-
if ($callback) {
116-
$this->sortCallback = $callback;
117-
}
115+
$this->sortCallback = $callback;
118116

119117
return $this;
120118
}

0 commit comments

Comments
 (0)