v4l2_device, pisp_utils: Add support for "RGBX8888"

By analogy with our existing "RGB888", define "RGBX8888" to be
RGBX in byte address order, i.e. V4L2-style rather than DRM-style.
This implies that the ORDER_SWAPPED flag should not be set.

These strings are private to libpisp and mostly used only by convert.

Signed-off-by: Nick Hollinghurst <[email protected]>

Author: njhollinghurst

src/helpers/v4l2_device.cpp

@@ -31,6 +31,7 @@ static FormatInfo get_v4l2_format(const std::string &format)
 {
 	std::map<std::string, FormatInfo> formats {
 		{ "RGB888", { V4L2_PIX_FMT_RGB24, 1 } },
+		{ "RGBX8888", { V4L2_PIX_FMT_RGBX32, 1 } },
 		{ "YUV420P", { V4L2_PIX_FMT_YUV420, 1 } },
 		{ "YUV422P", { V4L2_PIX_FMT_YUV422P, 1 } },
 		{ "YUV444P", { V4L2_PIX_FMT_YUV444M, 3 } },

src/libpisp/common/pisp_utils.cpp

@@ -240,7 +240,7 @@ static const std::map<std::string, uint32_t> &formats_table()
 		{ "NV61", PISP_IMAGE_FORMAT_THREE_CHANNEL + PISP_IMAGE_FORMAT_BPS_8 + PISP_IMAGE_FORMAT_SAMPLING_422 +
 					  PISP_IMAGE_FORMAT_PLANARITY_SEMI_PLANAR + PISP_IMAGE_FORMAT_ORDER_SWAPPED },
 		{ "RGB888", PISP_IMAGE_FORMAT_THREE_CHANNEL },
-		{ "RGBX8888", PISP_IMAGE_FORMAT_THREE_CHANNEL + PISP_IMAGE_FORMAT_BPP_32 + PISP_IMAGE_FORMAT_ORDER_SWAPPED },
+		{ "RGBX8888", PISP_IMAGE_FORMAT_THREE_CHANNEL + PISP_IMAGE_FORMAT_BPP_32 },
 		{ "RGB161616", PISP_IMAGE_FORMAT_THREE_CHANNEL + PISP_IMAGE_FORMAT_BPS_16 },
 		{ "BAYER", PISP_IMAGE_FORMAT_BPS_16 + PISP_IMAGE_FORMAT_UNCOMPRESSED },
 		{ "PISP_COMP1", PISP_IMAGE_FORMAT_COMPRESSION_MODE_1 },