Adding Pisound Micro kernel module #1588
pelwellcheckpatch.yml
on: pull_request
checkpatch review
1m 28s
Annotations
10 errors
|
checkpatch review
WARNING: Missing commit description - Add an appropriate one
|
|
checkpatch review
WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
|
|
checkpatch review:
sound/drivers/Kconfig#L276
WARNING: please write a help paragraph that fully describes the config symbol
|
|
checkpatch review:
sound/drivers/upisnd/upisnd_codec.c#L1736
WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity")
|
|
checkpatch review:
sound/drivers/upisnd/upisnd_comm.c#L73
WARNING: Prefer [subsystem eg: netdev]_dbg([subsystem]dev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ...
|
|
checkpatch review:
sound/drivers/upisnd/upisnd_comm.c#L77
WARNING: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(... to printk(KERN_CONT ...
|
|
checkpatch review:
sound/drivers/upisnd/upisnd_comm.c#L77
WARNING: Avoid logging continuation uses where feasible
|
|
checkpatch review:
sound/drivers/upisnd/upisnd_comm.c#L78
WARNING: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(... to printk(KERN_CONT ...
|
|
checkpatch review:
sound/drivers/upisnd/upisnd_comm.c#L78
WARNING: Avoid logging continuation uses where feasible
|
|
checkpatch review:
sound/drivers/upisnd/upisnd_comm.c#L196
WARNING: Prefer [subsystem eg: netdev]_dbg([subsystem]dev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ...
|