Skip to content

Commit 0b216b3

Browse files
6by9pelwell
authored andcommitted
drm: Validate connector rotation has one bit set in the rotation property
Copy the same validation logic as from the plane rotation property. Fixes: 8fec3ff ("drm: Add a rotation parameter to connectors.") Signed-off-by: Dave Stevenson <[email protected]>
1 parent af4ab4f commit 0b216b3

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

drivers/gpu/drm/drm_atomic_uapi.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -812,6 +812,12 @@ static int drm_atomic_connector_set_property(struct drm_connector *connector,
812812
} else if (property == connector->privacy_screen_sw_state_property) {
813813
state->privacy_screen_sw_state = val;
814814
} else if (property == connector->rotation_property) {
815+
if (!is_power_of_2(val & DRM_MODE_ROTATE_MASK)) {
816+
drm_dbg_atomic(connector->dev,
817+
"[CONNECTOR:%d:%s] bad rotation bitmask: 0x%llx\n",
818+
connector->base.id, connector->name, val);
819+
return -EINVAL;
820+
}
815821
state->rotation = val;
816822
} else if (connector->funcs->atomic_set_property) {
817823
return connector->funcs->atomic_set_property(connector,

0 commit comments

Comments
 (0)