Skip to content

Commit 1f41d24

Browse files
committed
drivers: media: pisp_be: Remove unused fields in struct pisp_be_config
These fields should not be set by either the user or the kernel driver so remove them. Replace them with padding bytes to maintain backward compatibility with existing userland applications. Signed-off-by: Naushir Patuck <[email protected]>
1 parent a73ecaf commit 1f41d24

File tree

1 file changed

+4
-20
lines changed

1 file changed

+4
-20
lines changed

include/uapi/linux/media/raspberrypi/pisp_be_config.h

Lines changed: 4 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -774,15 +774,8 @@ struct pisp_be_hog_buffer_config {
774774
* @dirty_flags_extra: Extra dirty flags
775775
*/
776776
struct pisp_be_config {
777-
/* I/O configuration: */
778-
struct pisp_be_input_buffer_config input_buffer;
779-
struct pisp_be_tdn_input_buffer_config tdn_input_buffer;
780-
struct pisp_be_stitch_input_buffer_config stitch_input_buffer;
781-
struct pisp_be_tdn_output_buffer_config tdn_output_buffer;
782-
struct pisp_be_stitch_output_buffer_config stitch_output_buffer;
783-
struct pisp_be_output_buffer_config
784-
output_buffer[PISP_BACK_END_NUM_OUTPUTS];
785-
struct pisp_be_hog_buffer_config hog_buffer;
777+
/* For backward compatibility */
778+
uint8_t pad0[112];
786779
/* Processing configuration: */
787780
struct pisp_be_global_config global;
788781
struct pisp_image_format_config input_format;
@@ -823,17 +816,8 @@ struct pisp_be_config {
823816
output_format[PISP_BACK_END_NUM_OUTPUTS];
824817
struct pisp_be_hog_config hog;
825818
struct pisp_be_axi_config axi;
826-
/* Non-register fields: */
827-
struct pisp_be_lsc_extra lsc_extra;
828-
struct pisp_be_cac_extra cac_extra;
829-
struct pisp_be_downscale_extra
830-
downscale_extra[PISP_BACK_END_NUM_OUTPUTS];
831-
struct pisp_be_resample_extra resample_extra[PISP_BACK_END_NUM_OUTPUTS];
832-
struct pisp_be_crop_config crop;
833-
struct pisp_image_format_config hog_format;
834-
__u32 dirty_flags_bayer; /* these use pisp_be_bayer_enable */
835-
__u32 dirty_flags_rgb; /* use pisp_be_rgb_enable */
836-
__u32 dirty_flags_extra; /* these use pisp_be_dirty_t */
819+
/* For backward compatibility */
820+
uint8_t pad1[84];
837821
} __attribute__((packed));
838822

839823
/**

0 commit comments

Comments
 (0)