Skip to content

Commit 544ff7f

Browse files
jernejskgregkh
authored andcommitted
Revert "arm64: dts: allwinner: h6: Use RSB for AXP805 PMIC connection"
[ Upstream commit 573f99c ] This reverts commit 531fdbe. Hardware that uses I2C wasn't designed with high speeds in mind, so communication with PMIC via RSB can intermittently fail. Go back to I2C as higher speed and efficiency isn't worth the trouble. Fixes: 531fdbe ("arm64: dts: allwinner: h6: Use RSB for AXP805 PMIC connection") Link: LibreELEC/LibreELEC.tv#7731 Signed-off-by: Jernej Skrabec <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Chen-Yu Tsai <[email protected]> Signed-off-by: Sasha Levin <[email protected]>
1 parent 111a892 commit 544ff7f

File tree

3 files changed

+37
-37
lines changed

3 files changed

+37
-37
lines changed

arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -151,28 +151,12 @@
151151
vcc-pg-supply = <&reg_aldo1>;
152152
};
153153

154-
&r_ir {
155-
linux,rc-map-name = "rc-beelink-gs1";
156-
status = "okay";
157-
};
158-
159-
&r_pio {
160-
/*
161-
* FIXME: We can't add that supply for now since it would
162-
* create a circular dependency between pinctrl, the regulator
163-
* and the RSB Bus.
164-
*
165-
* vcc-pl-supply = <&reg_aldo1>;
166-
*/
167-
vcc-pm-supply = <&reg_aldo1>;
168-
};
169-
170-
&r_rsb {
154+
&r_i2c {
171155
status = "okay";
172156

173-
axp805: pmic@745 {
157+
axp805: pmic@36 {
174158
compatible = "x-powers,axp805", "x-powers,axp806";
175-
reg = <0x745>;
159+
reg = <0x36>;
176160
interrupt-parent = <&r_intc>;
177161
interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_LOW>;
178162
interrupt-controller;
@@ -290,6 +274,22 @@
290274
};
291275
};
292276

277+
&r_ir {
278+
linux,rc-map-name = "rc-beelink-gs1";
279+
status = "okay";
280+
};
281+
282+
&r_pio {
283+
/*
284+
* PL0 and PL1 are used for PMIC I2C
285+
* don't enable the pl-supply else
286+
* it will fail at boot
287+
*
288+
* vcc-pl-supply = <&reg_aldo1>;
289+
*/
290+
vcc-pm-supply = <&reg_aldo1>;
291+
};
292+
293293
&spdif {
294294
pinctrl-names = "default";
295295
pinctrl-0 = <&spdif_tx_pin>;

arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -175,16 +175,12 @@
175175
vcc-pg-supply = <&reg_vcc_wifi_io>;
176176
};
177177

178-
&r_ir {
179-
status = "okay";
180-
};
181-
182-
&r_rsb {
178+
&r_i2c {
183179
status = "okay";
184180

185-
axp805: pmic@745 {
181+
axp805: pmic@36 {
186182
compatible = "x-powers,axp805", "x-powers,axp806";
187-
reg = <0x745>;
183+
reg = <0x36>;
188184
interrupt-parent = <&r_intc>;
189185
interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_LOW>;
190186
interrupt-controller;
@@ -295,6 +291,10 @@
295291
};
296292
};
297293

294+
&r_ir {
295+
status = "okay";
296+
};
297+
298298
&rtc {
299299
clocks = <&ext_osc32k>;
300300
};

arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -112,20 +112,12 @@
112112
vcc-pg-supply = <&reg_aldo1>;
113113
};
114114

115-
&r_ir {
116-
status = "okay";
117-
};
118-
119-
&r_pio {
120-
vcc-pm-supply = <&reg_bldo3>;
121-
};
122-
123-
&r_rsb {
115+
&r_i2c {
124116
status = "okay";
125117

126-
axp805: pmic@745 {
118+
axp805: pmic@36 {
127119
compatible = "x-powers,axp805", "x-powers,axp806";
128-
reg = <0x745>;
120+
reg = <0x36>;
129121
interrupt-parent = <&r_intc>;
130122
interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_LOW>;
131123
interrupt-controller;
@@ -240,6 +232,14 @@
240232
};
241233
};
242234

235+
&r_ir {
236+
status = "okay";
237+
};
238+
239+
&r_pio {
240+
vcc-pm-supply = <&reg_bldo3>;
241+
};
242+
243243
&rtc {
244244
clocks = <&ext_osc32k>;
245245
};

0 commit comments

Comments
 (0)