Skip to content

Commit 6a97c88

Browse files
drm: rp1: rp1-vec: For progressive NTSC use 263 lines rather than 262
For NTSC, using an odd total number of lines inverts the colour phase between successive frames, which ameliorates false colour artifacts, although it slightly reduces frame rate from 60.05 Hz to 59.83 Hz. Progressive DRM modes with 262 lines remain supported. Signed-off-by: Nick Hollinghurst <[email protected]>
1 parent b84f979 commit 6a97c88

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/gpu/drm/rp1/rp1-vec/rp1_vec.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,9 @@ static int rp1vec_connector_get_modes(struct drm_connector *connector)
358358
mode->vdisplay >>= 1;
359359
mode->vsync_start >>= 1;
360360
mode->vsync_end >>= 1;
361-
mode->vtotal >>= 1;
361+
mode->vtotal >>= 1;
362+
if (mode->vtotal == 262 && tvstd <= DRM_MODE_TV_MODE_PAL)
363+
mode->vtotal++;
362364
} else if (mode->hdisplay == 704 && mode->vtotal == preferred_lines) {
363365
mode->type |= DRM_MODE_TYPE_PREFERRED;
364366
}

0 commit comments

Comments
 (0)