Skip to content

Commit 89b7e96

Browse files
committed
media: imx708: Remove registers from the tables that are also controls
Exposure, analogue gain, and digital gain are all being set from the tables of registers as well as via the control handler. The value in the tables is therefore redundant, so remove them. Signed-off-by: Dave Stevenson <[email protected]>
1 parent b1e40bd commit 89b7e96

File tree

1 file changed

+0
-32
lines changed

1 file changed

+0
-32
lines changed

drivers/media/i2c/imx708.c

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -293,8 +293,6 @@ static const struct cci_reg_sequence mode_common_regs[] = {
293293
static const struct cci_reg_sequence mode_4608x2592_regs[] = {
294294
{CCI_REG8(0x0342), 0x3D},
295295
{CCI_REG8(0x0343), 0x20},
296-
{CCI_REG8(0x0340), 0x0A},
297-
{CCI_REG8(0x0341), 0x59},
298296
{CCI_REG8(0x0344), 0x00},
299297
{CCI_REG8(0x0345), 0x00},
300298
{CCI_REG8(0x0346), 0x00},
@@ -352,20 +350,14 @@ static const struct cci_reg_sequence mode_4608x2592_regs[] = {
352350
{CCI_REG8(0x3CBD), 0x3C},
353351
{CCI_REG8(0x3CBE), 0x00},
354352
{CCI_REG8(0x3CBF), 0x00},
355-
{CCI_REG8(0x0202), 0x0A},
356-
{CCI_REG8(0x0203), 0x29},
357353
{CCI_REG8(0x0224), 0x01},
358354
{CCI_REG8(0x0225), 0xF4},
359355
{CCI_REG8(0x3116), 0x01},
360356
{CCI_REG8(0x3117), 0xF4},
361-
{CCI_REG8(0x0204), 0x00},
362-
{CCI_REG8(0x0205), 0x00},
363357
{CCI_REG8(0x0216), 0x00},
364358
{CCI_REG8(0x0217), 0x00},
365359
{CCI_REG8(0x0218), 0x01},
366360
{CCI_REG8(0x0219), 0x00},
367-
{CCI_REG8(0x020E), 0x01},
368-
{CCI_REG8(0x020F), 0x00},
369361
{CCI_REG8(0x3118), 0x00},
370362
{CCI_REG8(0x3119), 0x00},
371363
{CCI_REG8(0x311A), 0x01},
@@ -387,8 +379,6 @@ static const struct cci_reg_sequence mode_4608x2592_regs[] = {
387379
static const struct cci_reg_sequence mode_2x2binned_regs[] = {
388380
{CCI_REG8(0x0342), 0x1E},
389381
{CCI_REG8(0x0343), 0x90},
390-
{CCI_REG8(0x0340), 0x05},
391-
{CCI_REG8(0x0341), 0x38},
392382
{CCI_REG8(0x0344), 0x00},
393383
{CCI_REG8(0x0345), 0x00},
394384
{CCI_REG8(0x0346), 0x00},
@@ -446,20 +436,14 @@ static const struct cci_reg_sequence mode_2x2binned_regs[] = {
446436
{CCI_REG8(0x3CBD), 0x1E},
447437
{CCI_REG8(0x3CBE), 0x00},
448438
{CCI_REG8(0x3CBF), 0x0A},
449-
{CCI_REG8(0x0202), 0x05},
450-
{CCI_REG8(0x0203), 0x08},
451439
{CCI_REG8(0x0224), 0x01},
452440
{CCI_REG8(0x0225), 0xF4},
453441
{CCI_REG8(0x3116), 0x01},
454442
{CCI_REG8(0x3117), 0xF4},
455-
{CCI_REG8(0x0204), 0x00},
456-
{CCI_REG8(0x0205), 0x70},
457443
{CCI_REG8(0x0216), 0x00},
458444
{CCI_REG8(0x0217), 0x70},
459445
{CCI_REG8(0x0218), 0x01},
460446
{CCI_REG8(0x0219), 0x00},
461-
{CCI_REG8(0x020E), 0x01},
462-
{CCI_REG8(0x020F), 0x00},
463447
{CCI_REG8(0x3118), 0x00},
464448
{CCI_REG8(0x3119), 0x70},
465449
{CCI_REG8(0x311A), 0x01},
@@ -481,8 +465,6 @@ static const struct cci_reg_sequence mode_2x2binned_regs[] = {
481465
static const struct cci_reg_sequence mode_2x2binned_720p_regs[] = {
482466
{CCI_REG8(0x0342), 0x14},
483467
{CCI_REG8(0x0343), 0x60},
484-
{CCI_REG8(0x0340), 0x04},
485-
{CCI_REG8(0x0341), 0xB6},
486468
{CCI_REG8(0x0344), 0x03},
487469
{CCI_REG8(0x0345), 0x00},
488470
{CCI_REG8(0x0346), 0x01},
@@ -540,20 +522,14 @@ static const struct cci_reg_sequence mode_2x2binned_720p_regs[] = {
540522
{CCI_REG8(0x3CBD), 0x1E},
541523
{CCI_REG8(0x3CBE), 0x00},
542524
{CCI_REG8(0x3CBF), 0x05},
543-
{CCI_REG8(0x0202), 0x04},
544-
{CCI_REG8(0x0203), 0x86},
545525
{CCI_REG8(0x0224), 0x01},
546526
{CCI_REG8(0x0225), 0xF4},
547527
{CCI_REG8(0x3116), 0x01},
548528
{CCI_REG8(0x3117), 0xF4},
549-
{CCI_REG8(0x0204), 0x00},
550-
{CCI_REG8(0x0205), 0x70},
551529
{CCI_REG8(0x0216), 0x00},
552530
{CCI_REG8(0x0217), 0x70},
553531
{CCI_REG8(0x0218), 0x01},
554532
{CCI_REG8(0x0219), 0x00},
555-
{CCI_REG8(0x020E), 0x01},
556-
{CCI_REG8(0x020F), 0x00},
557533
{CCI_REG8(0x3118), 0x00},
558534
{CCI_REG8(0x3119), 0x70},
559535
{CCI_REG8(0x311A), 0x01},
@@ -575,8 +551,6 @@ static const struct cci_reg_sequence mode_2x2binned_720p_regs[] = {
575551
static const struct cci_reg_sequence mode_hdr_regs[] = {
576552
{CCI_REG8(0x0342), 0x14},
577553
{CCI_REG8(0x0343), 0x60},
578-
{CCI_REG8(0x0340), 0x0A},
579-
{CCI_REG8(0x0341), 0x5B},
580554
{CCI_REG8(0x0344), 0x00},
581555
{CCI_REG8(0x0345), 0x00},
582556
{CCI_REG8(0x0346), 0x00},
@@ -634,20 +608,14 @@ static const struct cci_reg_sequence mode_hdr_regs[] = {
634608
{CCI_REG8(0x3CBD), 0x32},
635609
{CCI_REG8(0x3CBE), 0x00},
636610
{CCI_REG8(0x3CBF), 0x00},
637-
{CCI_REG8(0x0202), 0x0A},
638-
{CCI_REG8(0x0203), 0x2B},
639611
{CCI_REG8(0x0224), 0x0A},
640612
{CCI_REG8(0x0225), 0x2B},
641613
{CCI_REG8(0x3116), 0x0A},
642614
{CCI_REG8(0x3117), 0x2B},
643-
{CCI_REG8(0x0204), 0x00},
644-
{CCI_REG8(0x0205), 0x00},
645615
{CCI_REG8(0x0216), 0x00},
646616
{CCI_REG8(0x0217), 0x00},
647617
{CCI_REG8(0x0218), 0x01},
648618
{CCI_REG8(0x0219), 0x00},
649-
{CCI_REG8(0x020E), 0x01},
650-
{CCI_REG8(0x020F), 0x00},
651619
{CCI_REG8(0x3118), 0x00},
652620
{CCI_REG8(0x3119), 0x00},
653621
{CCI_REG8(0x311A), 0x01},

0 commit comments

Comments
 (0)