spi: rp2040-gpio-bridge: Grow MAX_TRANSFER_SIZE

Increase the maximum SPI transfer size from an arbitrary 1 MiB to ~4 MiB
(the amount of data that can be referenced by a single manifest).

Signed-off-by: Richard Oliver <[email protected]>

Author: roliver-rpi

drivers/spi/spi-rp2040-gpio-bridge.c

@@ -31,10 +31,19 @@
 #define RP2040_GBDG_BLOCK_SIZE (RP2040_GBDG_FLASH_BLOCK_SIZE - MD5_SUFFIX_SIZE)
 
 /*
- * 1MiB transfer size is an arbitrary limit
  * Max value is 4173330 (using a single manifest)
+ *
+ * Internal page-size is 8KiB - 9 = 8183 bytes
+ * Manifests address data by a series of 16-byte MD5 sums (following a 16-byte
+ * manifest header)
+ *
+ * Max permissible data using a single manifest:
+ *   8183 * (8183//16 - 1) = 4173330
+ *
+ * CMD_DAT_EMIT in fast_xfer/bypass_cache mode could potentially allow a max
+ * transfer size of 4GiB, but this is not currently implemented.
  */
-#define MAX_TRANSFER_SIZE (1024U * ONE_KIB)
+#define MAX_TRANSFER_SIZE 4173330
 
 #define HALF_BUFFER (4U * ONE_KIB)
 
@@ -58,7 +67,7 @@ static_assert(sizeof(struct rp2040_gbdg_device_info) == TOTAL_RD_HDR_SIZE);
 static_assert(MD5_DIGEST_SIZE == MANIFEST_UNIT_SIZE);
 #define MANIFEST_HEADER_UNITS 1
 #define MANIFEST_DATA_UNITS \
-	DIV_ROUND_UP(MAX_TRANSFER_SIZE, RP2040_GBDG_BLOCK_SIZE)
+	DIV_ROUND_UP((1024U * ONE_KIB), RP2040_GBDG_BLOCK_SIZE)
 
 #define STATUS_BUSY 0x01