Skip to content

Commit ae0d63e

Browse files
nathanchancegregkh
authored andcommitted
i3c: master: svc: Fix implicit fallthrough in svc_i3c_master_ibi_work()
commit e8d2d28 upstream. Clang warns (or errors with CONFIG_WERROR=y): drivers/i3c/master/svc-i3c-master.c:596:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough] 596 | default: | ^ drivers/i3c/master/svc-i3c-master.c:596:2: note: insert 'break;' to avoid fall-through 596 | default: | ^ | break; 1 error generated. Clang is a little more pedantic than GCC, which does not warn when falling through to a case that is just break or return. Clang's version is more in line with the kernel's own stance in deprecated.rst, which states that all switch/case blocks must end in either break, fallthrough, continue, goto, or return. Add the missing break to silence the warning. Fixes: 0430bf9 ("i3c: master: svc: Fix missing STOP for master request") Signed-off-by: Nathan Chancellor <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alexandre Belloni <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 73c4707 commit ae0d63e

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/i3c/master/svc-i3c-master.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -512,6 +512,7 @@ static void svc_i3c_master_ibi_work(struct work_struct *work)
512512
break;
513513
case SVC_I3C_MSTATUS_IBITYPE_MASTER_REQUEST:
514514
svc_i3c_master_emit_stop(master);
515+
break;
515516
default:
516517
break;
517518
}

0 commit comments

Comments
 (0)