Skip to content

Commit c45a1db

Browse files
HoratiuVulturgregkh
authored andcommitted
net: phy: micrel: Fix lan8814_config_init
commit bf91f4b upstream. The blamed commit introduced the function lanphy_modify_page_reg which as name suggests it, it modifies the registers. In the same commit we have started to use this function inside the drivers. The problem is that in the function lan8814_config_init we passed the wrong page number when disabling the aneg towards host side. We passed extended page number 4(LAN8814_PAGE_COMMON_REGS) instead of extended page 5(LAN8814_PAGE_PORT_REGS) Fixes: a0de636 ("net: phy: micrel: Introduce lanphy_modify_page_reg") Signed-off-by: Horatiu Vultur <[email protected]> Reviewed-by: Simon Horman <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 6dce434 commit c45a1db

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/phy/micrel.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4085,7 +4085,7 @@ static int lan8814_config_init(struct phy_device *phydev)
40854085
struct kszphy_priv *lan8814 = phydev->priv;
40864086

40874087
/* Disable ANEG with QSGMII PCS Host side */
4088-
lanphy_modify_page_reg(phydev, LAN8814_PAGE_COMMON_REGS,
4088+
lanphy_modify_page_reg(phydev, LAN8814_PAGE_PORT_REGS,
40894089
LAN8814_QSGMII_PCS1G_ANEG_CONFIG,
40904090
LAN8814_QSGMII_PCS1G_ANEG_CONFIG_ANEG_ENA,
40914091
0);

0 commit comments

Comments
 (0)