Skip to content

Commit e6d477a

Browse files
mairacanalpelwell
authored andcommitted
drm/v3d: Don't retrieve the clock twice
Upstream commit d3976b4 ("drm/v3d: Add clock handling") introduced clock handling. Therefore, delete the clock handling previously introduced in downstream. Signed-off-by: Maíra Canal <[email protected]>
1 parent 0dc20a3 commit e6d477a

File tree

1 file changed

+8
-11
lines changed

1 file changed

+8
-11
lines changed

drivers/gpu/drm/v3d/v3d_drv.c

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -395,21 +395,18 @@ static int v3d_platform_drm_probe(struct platform_device *pdev)
395395
}
396396
}
397397

398-
v3d->clk = devm_clk_get(dev, NULL);
399-
if (IS_ERR_OR_NULL(v3d->clk)) {
400-
if (PTR_ERR(v3d->clk) != -EPROBE_DEFER)
401-
dev_err(dev, "Failed to get clock (%ld)\n", PTR_ERR(v3d->clk));
402-
return PTR_ERR(v3d->clk);
403-
}
404-
405398
node = rpi_firmware_find_node();
406-
if (!node)
407-
return -EINVAL;
399+
if (!node) {
400+
ret = -EINVAL;
401+
goto clk_disable;
402+
}
408403

409404
firmware = rpi_firmware_get(node);
410405
of_node_put(node);
411-
if (!firmware)
412-
return -EPROBE_DEFER;
406+
if (!firmware) {
407+
ret = -EPROBE_DEFER;
408+
goto clk_disable;
409+
}
413410

414411
v3d->clk_up_rate = rpi_firmware_clk_get_max_rate(firmware,
415412
RPI_FIRMWARE_V3D_CLK_ID);

0 commit comments

Comments
 (0)