Make examples friendlier for non GCC compilers and fixed slave_mem_i2c.c to compile on boards without I2C pins (#336)

Author: kilograham

CMakeLists.txt

@@ -28,8 +28,10 @@ add_subdirectory(hello_world)
 add_compile_options(-Wall
         -Wno-format          # int != int32_t as far as the compiler is concerned because gcc has int32_t as long int
         -Wno-unused-function # we have some for the docs that aren't called
-        -Wno-maybe-uninitialized
         )
+if (CMAKE_C_COMPILER_ID STREQUAL "GNU")
+    add_compile_options(-Wno-maybe-uninitialized)
+endif()
 
 # Hardware-specific examples in subdirectories:
 add_subdirectory(adc)

adc/adc_console/adc_console.c

@@ -72,7 +72,7 @@ int main(void) {
                     printf("%03x\n", sample_buf[i]);
                 break;
             }
-            case 'w':
+            case 'w': {
                 printf("\nPress any key to stop wiggling\n");
                 int i = 1;
                 gpio_set_dir_all_bits(-1);
@@ -85,6 +85,7 @@ int main(void) {
                 gpio_set_dir_all_bits(0);
                 printf("Wiggling halted.\n");
                 break;
+            }
             case '\n':
             case '\r':
                 break;

adc/microphone_adc/microphone_adc.c

@@ -44,6 +44,4 @@ int main() {
         printf("%.2f\n", adc_raw * ADC_CONVERT);
         sleep_ms(10);
     }
-
-    return 0;
 }

adc/onboard_temperature/onboard_temperature.c

@@ -58,6 +58,4 @@ int main() {
 #endif
         sleep_ms(990);
     }
-
-    return 0;
 }

flash/cache_perfctr/flash_cache_perfctr.c

@@ -79,7 +79,9 @@ int main() {
     printf("Hit rate so far: %.1f%%\n", hit * 100.f / access);
 
     printf("Calculate 25th fibonacci number: %d\n", recursive_fibonacci(25));
-    printf("New hit rate after printf and fibonacci: %.1f%%\n", xip_ctrl_hw->ctr_hit * 100.f / xip_ctrl_hw->ctr_acc);
+    uint32_t ctr_hit = xip_ctrl_hw->ctr_hit;
+    uint32_t ctr_acc = xip_ctrl_hw->ctr_acc;
+    printf("New hit rate after printf and fibonacci: %.1f%%\n", ctr_hit * 100.f / ctr_acc);
 
     check_hit_miss_invalidate();
 

flash/nuke/nuke.c

@@ -17,7 +17,7 @@
 //
 // To the CMakeLists.txt app for this file. Just to be sure, we can check the
 // define:
-#if !PICO_NO_FLASH
+#if !PICO_NO_FLASH && !PICO_COPY_TO_RAM
 #error "This example must be built to run from SRAM!"
 #endif
 

gpio/hello_7segment/hello_7segment.c

@@ -89,7 +89,5 @@ int main() {
         sleep_ms(250);
         gpio_clr_mask(mask);
     }
-
-    return 0;
 }
 /// \end::hello_gpio[]

gpio/hello_gpio_irq/hello_gpio_irq.c

@@ -27,8 +27,6 @@ int main() {
 
     // Wait forever
     while (1);
-
-    return 0;
 }
 
 

hello_world/serial/hello_serial.c

@@ -13,5 +13,4 @@ int main() {
         printf("Hello, world!\n");
         sleep_ms(1000);
     }
-    return 0;
 }

hello_world/usb/hello_usb.c

@@ -13,5 +13,4 @@ int main() {
         printf("Hello, world!\n");
         sleep_ms(1000);
     }
-    return 0;
 }