Skip to content

Commit 05ae14e

Browse files
committed
Review fixups
PICO_RP2350 -> !PICO_RP2040 eg -> e.g.
1 parent e66146a commit 05ae14e

File tree

2 files changed

+6
-6
lines changed
  • src/rp2_common

2 files changed

+6
-6
lines changed

src/rp2_common/hardware_rcp/include/hardware/rcp.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,14 @@
1515
*/
1616

1717
// ----------------------------------------------------------------------------
18-
// RCP masks (this header is RP2350 only)
19-
#if PICO_RP2350
18+
// RCP masks
19+
#if !PICO_RP2040
2020

2121
#define RCP_MASK_TRUE _u(0xa500a500)
2222
#define RCP_MASK_FALSE _u(0x00c300c3)
2323
#define RCP_MASK_INTXOR _u(0x96009600)
2424

25-
// RCP instructions (this header is Arm-only)
25+
// RCP instructions (these instructions are Arm-only)
2626
#if HAS_REDUNDANCY_COPROCESSOR
2727
// ----------------------------------------------------------------------------
2828
// Macros and inline functions for use in C files
@@ -997,7 +997,7 @@ rcp_switch_u8_to_ch_cl rcp_canary_check_nodelay_impl \tag, \x
997997
.endm
998998

999999
#endif // HAS_REDUNDANCY_COPROCESSOR
1000-
#endif // PICO_RP2350
1000+
#endif // !PICO_RP2040
10011001
#endif // __ASSEMBLER__
10021002
// ----------------------------------------------------------------------------
10031003

src/rp2_common/pico_bootrom/include/pico/bootrom.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1106,14 +1106,14 @@ int rom_add_flash_runtime_partition(uint32_t start_offset, uint32_t size, uint32
11061106
* issue, and returns `BOOTROM_ERROR_NOT_PERMITTED` if the partition chosen by `pick_ab_partition` also requires a flash erase version downgrade (as you can't
11071107
* erase 2 partitions with one `explicit_buy` call).
11081108
*
1109-
* It also checks that the chosen partition contained a valid image (eg a signed image when using secure boot), and returns `BOOTROM_ERROR_NOT_FOUND`
1109+
* It also checks that the chosen partition contained a valid image (e.g. a signed image when using secure boot), and returns `BOOTROM_ERROR_NOT_FOUND`
11101110
* if it does not.
11111111
*
11121112
* \param workarea_base base address of work area
11131113
* \param workarea_size size of work area
11141114
* \param partition_a_num the A partition of the pair
11151115
* \return >= 0 the partition number picked
1116-
* BOOTROM_ERROR_NOT_PERMITTED if not possible to do an update correctly, eg if both main image and data image are TBYB
1116+
* BOOTROM_ERROR_NOT_PERMITTED if not possible to do an update correctly, e.g. if both main image and data image are TBYB
11171117
* BOOTROM_ERROR_NOT_FOUND if the chosen partition failed verification
11181118
*/
11191119
int rom_pick_ab_update_partition(uint32_t *workarea_base, uint32_t workarea_size, uint partition_a_num);

0 commit comments

Comments
 (0)