Skip to content

Commit 07f2d71

Browse files
committed
review tweaks
1 parent 5e398e8 commit 07f2d71

File tree

2 files changed

+1
-14
lines changed

2 files changed

+1
-14
lines changed

src/rp2_common/pico_double/include/pico/double.h

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -95,14 +95,10 @@ extern "C" {
9595
*
9696
* int2double, uint2double, int642double, uint642double
9797
*
98-
* note: on `pico_double_vfp` the 32-bit functions are also provided as C macros too since they map to inline VFP code
99-
*
10098
* - (u)double -> int (round towards zero):
10199
*
102100
* double2int_z, double2uint_z, double2int64_z, double2uint64_z
103101
*
104-
* note: on `pico_double_vfp` the 32-bit functions are also provided as C macros too since they map to inline VFP code
105-
*
106102
* - (u)double -> int (round towards -infinity):
107103
*
108104
* double2int, double2uint, double2int64, double2uint64
@@ -113,23 +109,14 @@ extern "C" {
113109
*
114110
* fix2double, ufix2double, fix642double, ufix642double
115111
*
116-
* note: on `pico_double_vfp` the 32-bit functions are currently _only_ provided as C macros and must use a compile
117-
* time constant between 1 and 32 for the fixed point position
118-
*
119112
* - double -> (u)fix (round towards zero):
120113
*
121114
* double2fix_z, double2ufix_z, double2fix64_z, double2ufix64_z
122115
*
123-
* note: on `pico_double_vfp` the 32-bit functions are currently _only_ provided as C macros and must use a compile
124-
* time constant between 1 and 32 for the fixed point position
125-
*
126116
* - double -> (u)fix (round towards -infinity):
127117
*
128118
* double2fix, double2ufix, double2fix64, double2ufix64
129119
*
130-
* note: on `pico_double_vfp` the 32-bit functions are currently _only_ provided as C macros and must use a compile
131-
* time constant between 1 and 32 for the fixed point position
132-
*
133120
* - Even faster versions of divide and square-root functions that do not round correctly:
134121
*
135122
* ddiv_fast, sqrt_fast (these do not round correctly)

test/pico_float_test/custom_double_funcs_test.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ int test() {
242242
test_checki(double2int(-1.0), -1, "double2int5b");
243243
// todo test correct rounding around maximum precision
244244
test_checki(double2int(2147483646.0), INT32_MAX-1, "double2int6");
245-
test_checki(double2int(2147483647.0), INT32_MAX, "double2int6");
245+
test_checki(double2int(2147483647.0), INT32_MAX, "double2int6b");
246246
test_checki(double2int(21474836470.0), INT32_MAX, "double2int7");
247247
test_checki(double2int(-2147483648.0), INT32_MIN, "double2int8");
248248
test_checki(double2int(-21474836480.0), INT32_MIN, "double2int9");

0 commit comments

Comments
 (0)