Skip to content

Commit 3cb21c8

Browse files
authored
pico_bootrom: bootrom.h: fix -Wstrict-prototypes (#1888)
The refactoring of these functions removed the (void) in the function declarations - thus compiling with -Wstrict-prototypes will yell at us at compile time. Signed-off-by: Stefan Kerkmann <[email protected]>
1 parent d886df6 commit 3cb21c8

File tree

1 file changed

+4
-4
lines changed
  • src/rp2_common/pico_bootrom/include/pico

1 file changed

+4
-4
lines changed

src/rp2_common/pico_bootrom/include/pico/bootrom.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ static inline void __attribute__((noreturn)) reset_usb_boot(uint32_t usb_activit
274274
* bank 0 IOs are untouched.
275275
* \endif
276276
*/
277-
static inline void rom_connect_internal_flash() {
277+
static inline void rom_connect_internal_flash(void) {
278278
rom_connect_internal_flash_fn func = (rom_connect_internal_flash_fn) rom_func_lookup_inline(ROM_FUNC_CONNECT_INTERNAL_FLASH);
279279
func();
280280
}
@@ -305,7 +305,7 @@ static inline void rom_connect_internal_flash() {
305305
* device from its XIP state to a serial command state.
306306
* \endif
307307
*/
308-
static inline void rom_flash_exit_xip() {
308+
static inline void rom_flash_exit_xip(void) {
309309
rom_flash_exit_xip_fn func = (rom_flash_exit_xip_fn) rom_func_lookup_inline(ROM_FUNC_FLASH_EXIT_XIP);
310310
func();
311311
}
@@ -388,7 +388,7 @@ static inline void rom_flash_range_program(uint32_t addr, const uint8_t *data, s
388388
* No other operations are performed.
389389
* \endif
390390
*/
391-
static inline void rom_flash_flush_cache() {
391+
static inline void rom_flash_flush_cache(void) {
392392
rom_flash_flush_cache_fn func = (rom_flash_flush_cache_fn) rom_func_lookup_inline(ROM_FUNC_FLASH_FLUSH_CACHE);
393393
func();
394394
}
@@ -404,7 +404,7 @@ static inline void rom_flash_flush_cache() {
404404
* Note that the same setup is performed by flash_exit_xip(), and the RP2350 flash program/erase functions do not leave XIP in an
405405
* inaccessible state, so calls to this function are largely redundant on RP2350. It is provided on RP2350 for compatibility with RP2040.
406406
*/
407-
static inline void rom_flash_enter_cmd_xip() {
407+
static inline void rom_flash_enter_cmd_xip(void) {
408408
rom_flash_enter_cmd_xip_fn func = (rom_flash_enter_cmd_xip_fn) rom_func_lookup_inline(ROM_FUNC_FLASH_ENTER_CMD_XIP);
409409
func();
410410
}

0 commit comments

Comments
 (0)