Skip to content

Commit f258e01

Browse files
will-v-pilurch
andauthored
Apply suggestions from code review
Co-authored-by: Andrew Scheller <[email protected]>
1 parent 116d898 commit f258e01

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/rp2_common/pico_cyw43_driver/cyw43_firmware.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
if "#define CYW43_WIFI_FW_LEN" in line:
2020
matches = re.search(r"#define\s+\S+\s+\((\S+)\)", line)
2121
cyw43_wifi_fw_len = int(matches[1])
22-
if "#define CYW43_CLM_LEN" in line:
22+
elif "#define CYW43_CLM_LEN" in line:
2323
matches = re.search(r"#define\s+\S+\s+\((\S+)\)", line)
2424
cyw43_clm_len = int(matches[1])
2525
if cyw43_wifi_fw_len > 0 and cyw43_clm_len > 0:

src/rp2_common/pico_cyw43_driver/include/pico/cyw43_driver.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@
2323
#if CYW43_USE_FIRMWARE_PARTITION
2424
// PICO_CONFIG: CYW43_FIRMWARE_PARTITION_ID, ID of Wi-Fi firmware partition which must match the ID used in the partition table JSON, type=int, default=0x776966696669726d, group=pico_cyw43_driver
2525
#ifndef CYW43_FIRMWARE_PARTITION_ID
26-
#define CYW43_FIRMWARE_PARTITION_ID 0x776966696669726d // wififirm
26+
// The default 0x776966696669726d value is the ASCII encoding of "wififirm"
27+
#define CYW43_FIRMWARE_PARTITION_ID 0x776966696669726d
2728
#endif
2829
#endif
2930

0 commit comments

Comments
 (0)