Skip to content

Commit f76e0af

Browse files
Minor tweaks
1 parent f9201c5 commit f76e0af

File tree

3 files changed

+4
-14
lines changed

3 files changed

+4
-14
lines changed

bazel/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,11 +92,11 @@ you encounter along the way.
9292

9393
Currently, the following features are not supported:
9494

95+
* Pico W wireless libraries work, but may not have complete coverage.
96+
* Bazel does not yet provide RISC-V support for Pico 2/RP2350.
9597
* The pioasm parser cannot be built from source via Bazel.
9698
* Windows MSVC wildcard build (`bazel build //...`) does not work when targeting
9799
host.
98-
* Bazel does not yet provide RISC-V support for Pico 2/RP2350.
99-
* Pico W wireless libraries have link issues.
100100

101101
## Contributing
102102
When making changes to the Bazel build, please run the Bazel validation script

bazel/pico_btstack_make_gatt_header.bzl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
load("@rules_cc//cc:find_cc_toolchain.bzl", "find_cpp_toolchain", "use_cc_toolchain")
22

33
def _pico_btstack_make_gatt_header_impl(ctx):
4-
54
cc_toolchain = find_cpp_toolchain(ctx)
65
feature_configuration = cc_common.configure_features(
76
ctx = ctx,

bazel/util/label_flag_matches.bzl

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,8 @@
1+
"""A wrapper that enables a `config_setting` matcher for label_flag flags."""
2+
13
load("@bazel_skylib//rules:common_settings.bzl", "BuildSettingInfo")
24
load("@bazel_tools//tools/cpp:toolchain_utils.bzl", "find_cpp_toolchain", "use_cpp_toolchain")
35

4-
def _cc_toolchain_feature_is_enabled_impl(ctx):
5-
toolchain = find_cpp_toolchain(ctx)
6-
feature_configuration = cc_common.configure_features(
7-
ctx = ctx,
8-
cc_toolchain = toolchain,
9-
)
10-
val = cc_common.is_enabled(
11-
feature_configuration = feature_configuration,
12-
feature_name = ctx.attr.feature_name,
13-
)
14-
156
def _match_label_flag_impl(ctx):
167
matches = str(ctx.attr.expected_value.label) == str(ctx.attr.flag.label)
178
return [

0 commit comments

Comments
 (0)