host_hid mouse data displaced

[dshadoff]

Some wired mice (such as the official Raspberry Pi mouse) work with the host_hid USB example code in pico-examples - in fact, it seems that at the moment, only wired mice are recognized (although this is not the issue I wish to report here).

At least some wired mice which have side buttons (i.e. back/forward) have displaced data:

• button presses appear in the (hid_mouse_report_t).x element rather than (hid_mouse_report_t).button;
• x movement appears in (hid_mouse_report_t).y rather than (hid_mouse_report_t).x .
• (hid_mouse_report_t).button remains 1 (i.e. left button pressed)

(note: the mouse works fine on a RPi 400)

I am reporting this here as pico-sdk holds a non-current version of tinyusb, and it doesn't seem to be straightforward to test with the current tinyusb on pico hardware at the moment.

This may be solved with the newer version of tinyusb in pico-sdk 1.2.0 ... this issue can serve as a placeholder until that is available for test; if pico-sdk and tinyusb are in sync at that time (and if the issue is not yet resolved), I will be happy to report the issue upstream. I am also happy to gather any diagnostic information required (if the process is explained).

For the moment, the existence of a report may be helpful to other users, to indicate current known system limitations.

[kilograham]

please try with tinyusb-0.10.0 branch of this repo

[dhalbert]

Tagging @hathach

[dshadoff]

Having some trouble actually testing this.

I tried this by re-cloning the pico-sdk branch tinyusb-0.10.0 (in the original pico-sdk location), followed by rebuilding pico-examples.

When I first ran "cmake -B build" in pico-examples, a CMake warning came back, requiring me to go to the pico-sdk repo and run "git submodule update --init", in order to build any tinyusb examples (which I did).

I am assuming that this checked out the correct version of raspberrypi/tinyusb into pico-sdk/lib/tinyusb, although I wasn't able to find the commit ID on the expected branches. (commit ID was a long number terminating in "934cd935")

The build failed during the build of the tinyusb sources, in usb/device/dev_audio_headset, so I'm wondering if perhaps the link in the pico-sdk/lib/tinyusb on the tinyusb-0.10.0 branch is not fetching an appropriate version of the tinyusb module...

[kilograham]

ah - yeah, there isn't a checked in version o pico-examples to match tinyusb-0.10.0 (it has changed though)

you should be able to build from the examples/device directory in tinyusb though with PICO_SDK_PATH set.

[dshadoff]

To be clear, do you mean to:
cd (base)/pico-sdk/lib/tinyusb/examples/device
and then

cmake -B build
cd build
make

...Because this had problems during the cmake step:

CMake Error at cdc_msc_freertos/CMakeLists.txt:19 (message):
  Invalid FAMILY specified:


-- Configuring incomplete, errors occurred!

[kilograham]

that's a weird error (that makes me think you don't have the latest pico-0.10.0 tinyusb code)

That said, you need to specify a FAMILY and a BOARD e.g.

[kilograham]

cmake -DFAMILY=rp2040 -DBOARD=raspberry_pi_pico' -B build

you can use -DBOARD=pico_sdk too to just follow PICO_BOARD setting

[dshadoff]

That failed in a different way.

As for the version of the pico-0.10.0 tinyusb code, I cloned the tinyusb-0.10.0 branch of pico-sdk last night, and ran "git submodule update --init" which brought in whatever version was linked from lib/tinyusb in that branch... but I too was unclear whether it was the correct one.

Here is the most recent output:

Using PICO_SDK_PATH from environment ('/home/pi/devel/pico/pico-setup/pico/pico-sdk')
PICO_SDK_PATH is /home/pi/devel/pico/pico-setup/pico/pico-sdk
Defaulting PICO_PLATFORM to rp2040 since not specified.
Defaulting PICO platform compiler to pico_arm_gcc since not specified.
-- Defaulting build type to 'Release' since not specified.
PICO compiler is pico_arm_gcc
-- The C compiler identification is GNU 7.3.1
-- The CXX compiler identification is GNU 7.3.1
-- The ASM compiler identification is GNU
-- Found assembler: /usr/bin/arm-none-eabi-gcc
PICO target board is pico.
Using board configuration from /home/pi/devel/pico/pico-setup/pico/pico-sdk/src/boards/include/boards/pico.h
-- Found Python3: /usr/bin/python3.7 (found version "3.7.3") found components: Interpreter 
CMake Warning at ../../../../src/rp2_common/tinyusb/CMakeLists.txt:14 (message):
  PICO_TINYUSB_PATH specified but content not present.


Using PICO_EXAMPLES_PATH from environment ('/home/pi/devel/pico/pico-setup/pico/pico-examples')
-- Configuring done
CMake Error at net_lwip_webserver/CMakeLists.txt:16 (add_executable):
  Cannot find source file:

    /home/pi/devel/pico/pico-setup/pico/pico-sdk/lib/tinyusb/lib/lwip/src/core/altcp.c

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .m .M .mm .h .hh .h++ .hm
  .hpp .hxx .in .txx


-- Generating done
CMake Generate step failed.  Build files cannot be regenerated correctly.

[dshadoff]

Actually I realized...
The example I was looking to use is found in host, not device (host hid mouse device, as per the issue title).
So building in examples/device would appear to be incorrect.

When building in examples/host, it also failed (but in a different way):
cmake was fine
But make failed:

Scanning dependencies of target raspberry_pi_pico-cdc_msc_hid
[ 20%] Building C object cdc_msc_hid/CMakeFiles/raspberry_pi_pico-cdc_msc_hid.dir/src/hid_app.c.obj
/home/pi/devel/pico/pico-setup/pico/pico-sdk/lib/tinyusb/examples/host/cdc_msc_hid/src/hid_app.c:26:10: fatal error: bsp/board.h: No such file or directory
 #include "bsp/board.h"
          ^~~~~~~~~~~~~
compilation terminated.
make[2]: *** [cdc_msc_hid/CMakeFiles/raspberry_pi_pico-cdc_msc_hid.dir/build.make:63: cdc_msc_hid/CMakeFiles/raspberry_pi_pico-cdc_msc_hid.dir/src/hid_app.c.obj] Error 1
make[1]: *** [CMakeFiles/Makefile2:1631: cdc_msc_hid/CMakeFiles/raspberry_pi_pico-cdc_msc_hid.dir/all] Error 2
make: *** [Makefile:84: all] Error 2

[kilograham]

I don't think i realized you were building the standalone "tinyusb way" from within the tinyusb submodule of pico-sdk.
I assumed you were building from a standalone tinyusb depo pointing at a standalone pico-sdk via PICO_SDK_PATH

in any case, there pico-sdk->tinyusb did not have the latest submodule commit reference; i have updated

[dshadoff]

No, I had only been using the release version of pico-SDK, pico-examples, etc. until you asked me to test on a branch. I wouldn't feel comfortable opening an issue against anything but the release version.

I have good news/bad news to report:
First, I am now able to build the pico-sdk/lib/tinyusb/examples/host sources.

However, when I run the example - which should report mouse movements when I have a mouse plugged in - I get the following output with each of the mice I try - including the official Raspberry Pi mouse which worked fine on the release version (but didn't have forward/back buttons on the side).

----------------------------------------------------
TinyUSB Host Example
If you find any bugs or problems, feel free to open
an issue at https://github.com/hathach/tinyusb
----------------------------------------------------

This Host demo is configured to support:
  - RTOS = Raspberry Pi Pico SDK

*** PANIC ***

ep 0 in was already available

[hathach]

@dshadoff can you clone the upstream and cd to https://github.com/hathach/tinyusb/tree/master/examples/host/cdc_msc_hid then

make BOARD=raspberry_pi_pico all

then copy the uf2 to pico to test with.

[dshadoff]

OK, I interpreted that as:

cd (parent of pico-sdk)
git clone git://github.com/hathach/tinyusb
cd tinyusb/examples/host/cdc_msc_hid
make BOARD=raspberry_pi_pico all

This creates a separate tinyusb repository, adjacent to pico-sdk, and on the master git branch (which is more current than 0.10.0, as it had a commit as recently as 9 hours ago). Also, my pico-sdk is still on the tinyusb-0.10.0 branch.

Results are mostly good news:

The build went fine
The execution does not crash as my previous attempt did.

1. Raspberry Pi official mouse works as well as the previous pico-sdk examples did.
2. Logitech wireless mouse is still not recognized at all.
3. The wired mouse with forward/back side buttons works better than the previous release, but still not completely correctly:

• all 4 buttons now are recognized correctly and do not cause any confusing 'X' or 'Y' movements
• 'X' movements appear fine, except that the 'Y' value is either "0" (for positive X movement) or "-1" (for negative X movement)
• 'Y' movement is not reported in the report->Y, but rather in the wheel value
  So for some reason, this mouse appears as though it may be reporting 16-bit X and Y values ? In any case, it works fine on Windows and Linux machines...

[hathach]

sure there is a bug, now let test with the logitech mouse

1. can you uoload its report descriptor as txt file. If you are in linux you could dump it with sudo usbhid-dump -d cafe | grep -v : | xxd -r -p | hidrd-convert -o spec replace cafe with logitech vid
2. now run compile again with log enable (need to clean first)

make BOARD=raspberry_pi_pico clean
make BOARD=raspberry_pi_pico LOG=3 all

then post your log as txt file for analyzing.

you could also post the log with the 3) wired mouse fwd/bck not work right, but that would be later or better a separated issue.