Skip to content

Another orphaned branch - removing superfluous dependency #2303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2025
Merged

Another orphaned branch - removing superfluous dependency #2303

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b97b304
pico_lwip_arch is actually what depends on pico_rand
kilograham Feb 9, 2023
c9507a2
Merge branch 'develop' into lwip_deps
kilograham Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/rp2_common/pico_lwip/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ if (EXISTS ${PICO_LWIP_PATH}/${LWIP_TEST_PATH})
${PICO_LWIP_PATH}/src/netif/ppp/polarssl/sha1.c
)

pico_add_library(pico_lwip_apps)
# SNMPv3 agent
pico_add_library(pico_lwip_snmp NOFLAG)
target_sources(pico_lwip_snmp INTERFACE
Expand Down Expand Up @@ -264,6 +265,8 @@ if (EXISTS ${PICO_LWIP_PATH}/${LWIP_TEST_PATH})
pico_add_library(pico_lwip_arch NOFLAG)
target_include_directories(pico_lwip_arch_headers INTERFACE
${CMAKE_CURRENT_LIST_DIR}/include)
pico_mirrored_target_link_libraries(pico_lwip_arch INTERFACE
pico_rand)

# our nosys impl
pico_add_library(pico_lwip_nosys NOFLAG)
Expand All @@ -273,8 +276,7 @@ if (EXISTS ${PICO_LWIP_PATH}/${LWIP_TEST_PATH})
pico_mirrored_target_link_libraries(pico_lwip_nosys INTERFACE
pico_async_context_base
pico_lwip_arch
pico_lwip
pico_rand)
pico_lwip)

if (NOT PICO_LWIP_CONTRIB_PATH)
set(PICO_LWIP_CONTRIB_PATH ${PICO_LWIP_PATH}/contrib)
Expand All @@ -299,8 +301,7 @@ if (EXISTS ${PICO_LWIP_PATH}/${LWIP_TEST_PATH})
pico_mirrored_target_link_libraries(pico_lwip_freertos INTERFACE
pico_async_context_base
pico_lwip
pico_lwip_contrib_freertos
pico_rand)
pico_lwip_contrib_freertos)

pico_promote_common_scope_vars()
endif()