Skip to content

Fix incorrect Bazel dependency in host/hardware_irq #2739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix incorrect Bazel dependency in host/hardware_irq #2739

wants to merge 1 commit into from
+2 −1

Conversation

@rhulme
Copy link
Contributor

@rhulme rhulme commented Nov 30, 2025

Bazel configuration adds a dependency on hardware_claim in 'host' but it doesn't exist there. It's in 'common'.

Fixes #2738

@rhulme
Fix incorrect Bazel dependency in host/hardware_irq
3fa6951 
Bazel configuration adds a dependency on hardware_claim in 'host' but
it doesn't exist there.  It's in 'common'.

Fixes raspberrypi#2738
armandomontanez
armandomontanez approved these changes Dec 1, 2025
View reviewed changes
Copy link
Contributor

@armandomontanez armandomontanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Because of #2596, you might be able to remove tags = ["manual"] from this too

@rhulme
Copy link
Contributor Author

rhulme commented Dec 3, 2025 •
edited
Loading

Thanks! Because of #2596, you might be able to remove tags = ["manual"] from this too

I haven't got my head around how exactly Bazel does things yet. I just tried running the command from the Bazel build checks (which seem to be permanently failing anyway).

I noticed host/hardware_irq still has issues because PICO_NUM_VTABLE_IRQS is not defined. That's not a Bazel issue directly, more a debug/release build issue. It seems that Bazel creates a debug build by default, so the assertion in check_irq_param becomes 'live' and the compiler complains about the undefined value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@armandomontanez armandomontanez armandomontanez approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

build host

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rhulme @armandomontanez @lurch