Skip to content

Commit 05dc290

Browse files
committed
Fix #97, Pico SDK version selector as advanced option for examples
Signed-off-by: paulober <[email protected]>
1 parent 7371ab2 commit 05dc290

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

src/webview/newProjectPanel.mts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1837,7 +1837,7 @@ export class NewProjectPanel {
18371837
</div>
18381838
</div>
18391839
<div class="grid gap-6 md:grid-cols-2 mt-6">
1840-
<div>
1840+
<div id="pico-sdk-selector">
18411841
<label for="sel-pico-sdk" class="block mb-2 text-sm font-medium text-gray-900 dark:text-white">Select Pico SDK version</label>
18421842
<select id="sel-pico-sdk" class="bg-gray-50 border border-gray-300 text-gray-900 text-sm rounded-lg focus:ring-blue-500 focus:border-blue-500 block w-full p-2.5 dark:bg-gray-700 dark:border-gray-600 dark:placeholder-gray-400 dark:text-white dark:focus:ring-blue-500 dark:focus:border-blue-500">
18431843
${picoSDKsHtml}

web/nav.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,11 +109,15 @@ window.toggleCreateFromExampleMode = function (forceOn, forceOff) {
109109
const projectNameGrid = document.getElementById('project-name-grid');
110110
const projectNameDropdownButton = document.getElementById('project-name-dropdown-button');
111111
const defaultBoardTypeOption = document.getElementById('sel-default');
112+
const picoSDKSelector = document.getElementById('pico-sdk-selector');
112113

113114
if (isExampleMode && (forceOn === undefined || !forceOn) && (forceOff === undefined || forceOff)) {
114115
// clear input to avoid crashing the webview
115116
projectNameInput.value = '';
116117

118+
picoSDKSelector.classList.remove('advanced-option');
119+
picoSDKSelector.hidden = false;
120+
117121
if (createFromExampleBtn) {
118122
createFromExampleBtn.setAttribute('data-example-mode', 'false');
119123
createFromExampleBtn.innerText = 'Example';
@@ -166,6 +170,9 @@ window.toggleCreateFromExampleMode = function (forceOn, forceOff) {
166170
hideCustomInputs(projectOptionsDivs, false);
167171
}
168172
} else if (forceOff === undefined || !forceOff) {
173+
picoSDKSelector.classList.add('advanced-option');
174+
picoSDKSelector.hidden = true;
175+
169176
if (createFromExampleBtn) {
170177
createFromExampleBtn.setAttribute('data-example-mode', 'true');
171178
createFromExampleBtn.innerText = 'Custom';

0 commit comments

Comments
 (0)