Fix #19 - throw error when debugging if compilation fails

Signed-off-by: William Vinnicombe <[email protected]>

Author: will-v-pi

src/commands/compileProject.mts

@@ -1,10 +1,10 @@
 import { commands, tasks, window } from "vscode";
 import { EventEmitter } from 'events';
-import { Command } from "./command.mjs";
+import { CommandWithResult } from "./command.mjs";
 import Logger from "../logger.mjs";
 import Settings, { SettingsKey } from "../settings.mjs";
 
-export default class CompileProjectCommand extends Command {
+export default class CompileProjectCommand extends CommandWithResult<boolean> {
   private _logger: Logger = new Logger("CompileProjectCommand");
 
   public static readonly id = "compileProject";
@@ -13,7 +13,7 @@ export default class CompileProjectCommand extends Command {
     super(CompileProjectCommand.id);
   }
 
-  async execute(): Promise<void> {
+  async execute(): Promise<boolean> {
     // Get the task with the specified name
     const task = (await tasks.fetchTasks()).find(task => () => {
       console.log(`[TASK] ${task.name}`);
@@ -30,7 +30,7 @@ export default class CompileProjectCommand extends Command {
         "cmake.launchTargetPath"
       );
 
-      return;
+      return true;
     }
 
     if (task) {
@@ -67,12 +67,15 @@ export default class CompileProjectCommand extends Command {
       this._logger.debug(
         "Task 'Compile Project' completed with code " + code.toString()
       );
+
+      return code === 0;
     } else {
       // Task not found
       this._logger.error("Task 'Compile Project' not found.");
       void window.showErrorMessage("Task 'Compile Project' not found.");
+
+      return false;
     }
 
-    return;
   }
 }

src/commands/launchTargetPath.mts

@@ -85,7 +85,15 @@ export default class LaunchTargetPathCommand extends CommandWithResult<string> {
     }
 
     // Compile before returning
-    await commands.executeCommand("raspberry-pi-pico.compileProject");
+    const compiled = await commands.executeCommand(
+      "raspberry-pi-pico.compileProject"
+    );
+
+    if (!compiled) {
+      throw new Error(
+        "Failed to compile project - check output from the Compile Project task"
+      );
+    }
 
     return join(fsPathFolder, "build", projectName + ".elf").replaceAll(
       "\\",

src/extension.mts

@@ -79,7 +79,10 @@ export async function activate(context: ExtensionContext): Promise<void> {
   const ui = new UI(picoProjectActivityBarProvider);
   ui.init();
 
-  const COMMANDS: Array<Command | CommandWithResult<string> | CommandWithArgs> =
+  const COMMANDS: Array<
+    Command | CommandWithResult<string> |
+    CommandWithResult<boolean> | CommandWithArgs
+  > =
     [
       new NewProjectCommand(context.extensionUri),
       new SwitchSDKCommand(ui, context.extensionUri),