Skip to content

Commit 9fd8600

Browse files
committed
Fix panels not disposed if loading of settings failed
Signed-off-by: paulober <[email protected]>
1 parent fc26a5c commit 9fd8600

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

src/webview/newMicroPythonProjectPanel.mts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,8 @@ export class NewMicroPythonProjectPanel {
7575

7676
const settings = Settings.getInstance();
7777
if (!settings) {
78+
panel.dispose();
79+
7880
// TODO: maybe add restart button
7981
void window.showErrorMessage(
8082
"Failed to load settings. Please restart VSCode."

src/webview/newProjectPanel.mts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -382,6 +382,8 @@ export class NewProjectPanel {
382382

383383
const settings = Settings.getInstance();
384384
if (settings === undefined) {
385+
panel.dispose();
386+
385387
// TODO: maybe add restart button
386388
void window.showErrorMessage(
387389
"Failed to load settings. Please restart VSCode."

0 commit comments

Comments
 (0)