Add support for looking into PICO_BOARD_HEADER_DIRS custom board header #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will-v-pi
requested changes
Dec 19, 2024
Collaborator
There was a problem hiding this comment.
Happy to merge this change - just a couple of whitespace issues which I'll fixup
Contributor
Author
There was a problem hiding this comment.
I added support to that variable as a path list,
If you add spaces at the end of the value, single quote characters are added at start and at the end.
This change will make this feature more robust.
will-v-pi
requested changes
Jan 6, 2025
Collaborator
will-v-pi
left a comment
will-v-pi
left a comment
There was a problem hiding this comment.
Thanks - if you could revert the changes to src/commands/launchTargetPath.mts so this just includes the board header dir changes, then I'm happy to merge this
shalxmva
force-pushed
the
custom_header_dir
branch
2 times, most recently
from
a0faaf8 to
0880a4e
Compare
files Add Use CMAKE_PROJECT_NAME from CMakeCache.txt when getting the project name
shalxmva
force-pushed
the
custom_header_dir
branch
from
0880a4e to
7ce1353
Compare
shalxmva
force-pushed
the
custom_header_dir
branch
from
7ce1353 to
0ec7812
Compare
Contributor
Author
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, i want to add support to reading custom headers boards by using the variable PICO_BOARD_HEADER_DIRS set at CMakeLists.txt (currently only one folder is being set at the variable). The reason is because there are people creating custom boards with custom flash chips.
Also our project is setting the project name using a CMake variable.
So any review is welcome to make this change more robust.
Thanks in advance!